Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deprecation warning when running Phase 1 pixel workflows #12465

Merged

Conversation

mark-grimes
Copy link

Because the phase 1 customisation function calls the postLS1 one, it prints out the "please use Run2 era" deprecation warning. This confuses users since they didn't ask to run the Run 2 customisation.
This disables that warning when running the cust_2017 and cust_2019 customisation functions.

The plan was to get the phase 1 era working instead but that's taking longer than expected.

@atricomi, @delaere, @boudoul, @makortel

@mark-grimes
Copy link
Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 17, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9789/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X.

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Nov 18, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 19, 2015
…arning

Disable deprecation warning when running Phase 1 pixel workflows
@davidlange6 davidlange6 merged commit cd6f639 into cms-sw:CMSSW_8_0_X Nov 19, 2015
@mark-grimes mark-grimes deleted the removePhase1EraDeprecatedWarning branch November 23, 2015 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants