Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two CSCTF plots for debugging MPC/TMB errors from CSC #12470

Merged
merged 1 commit into from Nov 24, 2015

Conversation

rjwang
Copy link
Contributor

@rjwang rjwang commented Nov 18, 2015

add two CSCTF plots for debugging MPC/TMB errors from CSC

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rjwang (Ren-Jie Wang) for CMSSW_7_5_X.

It involves the following packages:

DQM/L1TMonitor

@cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Nov 18, 2015

please test

@deguio
Copy link
Contributor

deguio commented Nov 18, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9802/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Nov 22, 2015

unfortunately this PR doesn't merge on top of #12505
please rebase on top of that branch

@rjwang
Copy link
Contributor Author

rjwang commented Nov 23, 2015

Does that mean we have to remake a PR with the latest release?

On Nov 22, 2015, at 12:42 PM, Federico De Guio notifications@github.com wrote:

unfortunately this PR doesn't merge on top of #12505 #12505
please rebase on top of that branch


Reply to this email directly or view it on GitHub #12470 (comment).

@slava77
Copy link
Contributor

slava77 commented Nov 23, 2015

#12505 isn't merged yet. It's not a matter of using the latest release. Two PRs (this and #12505 ) conflict with each other.

@rjwang
Copy link
Contributor Author

rjwang commented Nov 23, 2015

Then, what should I do from my side? can I see where is the conflict, and we do need this PR to be merged asap in order to help CSC debug any problems in the trigger path.

On Nov 23, 2015, at 9:00 AM, Slava Krutelyov notifications@github.com wrote:

#12505 #12505 isn't merged yet. It's not a matter of using the latest release. Two PRs (this and #12505 #12505 ) conflict with each other.


Reply to this email directly or view it on GitHub #12470 (comment).

@slava77
Copy link
Contributor

slava77 commented Nov 23, 2015

@deguio is this PR ready to go to 75X?
it sounds like you may have a higher priority for #12505 (else the issue of merging conflicts in #12470 (comment) doesn't seem clear).
Please clarify.
Thanks.

@deguio
Copy link
Contributor

deguio commented Nov 24, 2015

ciao @slava77
I believe that this one can be merged and #12505 can be rebased on top on the head.

this is a warning for @jingyucms

@slava77
Copy link
Contributor

slava77 commented Nov 24, 2015

merge

it's unclear when we make a new release though
[80X IBs were apparently OK with #12472 ]

cmsbuild added a commit that referenced this pull request Nov 24, 2015
add two CSCTF plots for debugging MPC/TMB errors from CSC
@cmsbuild cmsbuild merged commit 210889b into cms-sw:CMSSW_7_5_X Nov 24, 2015
@rjwang
Copy link
Contributor Author

rjwang commented Nov 24, 2015

Thanks.

On Nov 24, 2015, at 10:03 AM, Slava Krutelyov notifications@github.com wrote:

merge

it's unclear when we make a new release though


Reply to this email directly or view it on GitHub #12470 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants