move edm plugin FedRawDataInputSource definition in the plugin directory

[smuzaffar]

EDM plugin FedRawDataInputSource was defined in the shared library and so any edm plugin which links against EventFilterUtilities sees it and adds duplicate definitions.

this should fix the error we have see in the latest 80X IBs
https://cms-sw.github.io/relvalLogDetail.html#slc6_amd64_gcc493;CMSSW_8_0_X_2015-11-18-1100

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_8_0_X.

It involves the following packages:

EventFilter/Utilities

@cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[smuzaffar]

please test

make sure that DQM/BeamMonitor is also rebuild along with this change.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9825/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9827/console

[cmsbuild]

+1
Tested at: 6e59023
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12479/9827/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12479/9827/summary.html

There are some workflows for which there are errors in the baseline:
5.1 step 2
9.0 step 3
140.53 step 2
134.911 step 3
135.4 step 2
1306.0 step 3
25.0 step 3
1000.0 step 2
1001.0 step 2
1003.0 step 2
1330.0 step 3
50202.0 step 3
25202.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

[smuzaffar]

@davidlange6 , @slava77 I would like to include it for next IB 23h00
any objection including this? This is just a clean up for the wrong plugin definition in the shared library

[slava77]

@smuzaffar
which error is this fixing?

I see a lot of workflows failing due to

from DQM.BeamMonitor.AlcaBeamMonitorClient_cff import *
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2015-11-18-1100/python/DQM/BeamMonitor/__init__.py", line 2, in 
    __path__.append(os.path.dirname(os.path.abspath(__file__).rsplit('/DQM/BeamMonitor/',1)[0])+'/cfipython/slc6_amd64_gcc493/DQM/BeamMonitor')
NameError: name 'os' is not defined

how is this related?
(OTOH, the matrix tests in jenkins tests of this PR passed OK)

[slava77]

+1

for #12479 4f7132d

• code change looks OK
• jenkins tests pass (some tests failing in IB are passing with this PR; looks unrelated)

[smuzaffar]

FedRawDataInputSource plugin was wrongly defined in the EventFilterUtilities shared library which is then used by many plugins from DQM/BeamMonitor/plugins (see #12458 (comment)). when we build with -j N then all of these DQM/BeamMonitor plugins generate cfipython/ file and all try to write in cfipython/arch/DQM/BeamMonitor/init_.py file. Due to parallel writing this file got curropeted

#Automatically created by SCRAM
__path__.append(os.path.dirname(os.path.abspath(__file__).rsplit('/DQM/BeamMonitor/',1)[0])+'/cfipython/slc6_amd64_gcc493/DQM/BeamMonitor')
import os
__path__.append(os.path.dirname(os.path.abspath(__file__).rsplit('/DQM/BeamMonitor/',1)[0])+'/cfipython/slc6_amd64_gcc493/DQM/BeamMonitor’)

that is why we are seeing errors in IB

[slava77]

ah, ok, this is clear now
Please go ahead and merge this.

[smuzaffar]

merge