Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483) #12487

Merged
merged 4 commits into from Nov 20, 2015

Conversation

mverwe
Copy link
Contributor

@mverwe mverwe commented Nov 18, 2015

This PR superseeds #12483

Adds HLTPixelActivityHFSumEnergyFilter module. This filter checks correlation between number of pixel clusters and HF energy sum. The idea is to have a filter firing when the expected correlation is broken.

Remark 1 : This module is NOT for the pp reference run.
Remark 2 : This module is for PbPb run.

@kkrajczar
@icali
@ttrk

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mverwe (Marta Verweij) for CMSSW_7_5_X.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Nov 19, 2015

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Nov 19, 2015

@mverwe please use "Edit" button at the top and change the title of the PR to something meaningful and self-descriptive

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9835/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mverwe mverwe changed the title Cmssw 7 5 5 hlt filt pix fix (superseeds #12483) adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483) Nov 19, 2015
@Martin-Grunewald
Copy link
Contributor

This must be a normal (stream or global) EDFilter, not an HLTFilter, as it does not (and can not!) save any TriggerObjects. Please make the change.

@Martin-Grunewald
Copy link
Contributor

-1

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9853/console

@mverwe
Copy link
Contributor Author

mverwe commented Nov 19, 2015

We've addressed all comments. Let us know in case of further remarks.

@cmsbuild
Copy link
Contributor

Pull request #12487 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9859/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 20, 2015

merge

all new code

cmsbuild added a commit that referenced this pull request Nov 20, 2015
adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483)
@cmsbuild cmsbuild merged commit 381b938 into cms-sw:CMSSW_7_5_X Nov 20, 2015
@Martin-Grunewald
Copy link
Contributor

BTW, is there a PR for 76X as well? Please make one!

@mverwe
Copy link
Contributor Author

mverwe commented Nov 24, 2015

@Martin-Grunewald The PR for 76X will be done asap

cmsbuild added a commit that referenced this pull request Dec 6, 2015
pixel vs HF energy filter (76X version of #12487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants