Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIN ECAL monitoring of pulse fit fnctions #12494

Merged
merged 1 commit into from Dec 2, 2015

Conversation

rkunnawa
Copy link
Contributor

This is a DQMOffline module to check the chi squared of the fit functions in the ECAL. required to check during the PbPb data taking. This is the 80X version of the PR #12484.

@deguio
Copy link
Contributor

deguio commented Nov 19, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 19, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9843/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rkunnawa (Raghav Kunnawalkam Elayavalli) for CMSSW_8_0_X.

It involves the following packages:

DQMOffline/Ecal

@cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Nov 19, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@rkunnawa @deguio - apologies for the very generic question - why do we need a "HI" specific version of ecal pulse shape monitoring?

@rkunnawa
Copy link
Contributor Author

Hi @davidlange6, Since the heavy ion system doesnt have OOT PU we decided to use the "global" reco for online HLT and "multifit 50ns" for the offline reco. We did some studies on MC and run1 Data and wanted to monitor the performance of the fits in run2 data incase we have to request a re-reco with a different method. @yetkinyilmaz @mverwe @richard-cms can comment more about this.

@mverwe
Copy link
Contributor

mverwe commented Nov 23, 2015

Hi, this will be discussed today still with TSG. But it looks like we will start running with multi-fit in HLT since the risk of changing last moment is considered to be too high. We however want to monitor the behaviour so that in case multi-fit leads to a large signal loss in PbPb collisions, we detect it as soon as possible.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 2, 2015
HIN ECAL monitoring of pulse fit fnctions
@cmsbuild cmsbuild merged commit 09f318e into cms-sw:CMSSW_8_0_X Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants