Cleanup Static Analyzer Errors #12504
Conversation
ianna
commented
Nov 19, 2015
ianna
commented
- Dead assignment cleanup
- Dead increment cleanup
- Dead initialisation cleanup
|
A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_0_X. It involves the following packages: Geometry/CaloTopology @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
please test |
| @@ -86,7 +86,7 @@ void DDPixBarLayerUpgradeAlgo::execute(DDCompactView& cpv) { | |||
| DDMaterial matter(matname); | |||
| DDLogicalPart layer(solid.ddname(), matter, solid); | |||
|
|
|||
| double dr = coolRadius+0.5*ladderThick; | |||
| double dr;// = coolRadius+0.5*ladderThick; | |||
There was a problem hiding this comment.
How about moving this variable to inside the for loop for which it is used?
|
The tests are being triggered in jenkins. |
| @@ -1095,7 +1098,8 @@ void EcalElectronicsMapping::GetListofFEDs(const EcalEtaPhiRegion& region, std:: | |||
| } | |||
| int minR = minL + 18; | |||
| int maxR = maxL + 18; | |||
| int iR = minR; | |||
| // FIXME: Value stored to 'iR' during its initialization is never read | |||
| int iR; // = minR; | |||
There was a problem hiding this comment.
Since iR is only used in the while loop, you can just declare it there. Since the value is an int and will be on the stack anyway there would be no performance gain from having it outside the loop.
| @@ -1044,7 +1044,8 @@ unsigned int HcalTopology::detId2denseIdCALIB(const DetId& id) const { | |||
| //std::cout<<"CALIB_HO: "; | |||
| //there are 5 special calib crosstalk channels, one in each ring | |||
| if (channel==7) { | |||
| channel = 2; | |||
| // FIXME: Value stored to 'channel' is never read | |||
There was a problem hiding this comment.
No need for these comments.
|
Thanks for checking the analyzer and working on these. |
|
@Dr15Jones - done. Thanks! |
|
please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-rejected
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
…cleanup Cleanup Static Analyzer Errors
