add customization to switch to Global ECAL reco from multifit #12507
Conversation
|
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X. It involves the following packages: RecoHI/Configuration @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| def changeHeavyIonsToUseECALGlobalFit(process) : | ||
| process.load('RecoLocalCalo.EcalRecProducers.ecalGlobalUncalibRecHit_cfi') |
There was a problem hiding this comment.
it would be better if you can check first that process has caloReco.
if hasattr (process, "caloReco")
... the rest follows
this way we can less discrimanately pass this function even to the runTheMatrix.py
|
please make also 76X PR as well |
|
Okay will do. On Thu, Nov 19, 2015 at 2:49 PM, Slava Krutelyov notifications@github.com
|
|
Pull request #12507 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| process.ecalRecHitSequence) | ||
| process.ecalRecHit.EEuncalibRecHitCollection = cms.InputTag("ecalGlobalUncalibRecHit","EcalUncalibRecHitsEE") | ||
| process.ecalRecHit.EBuncalibRecHitCollection = cms.InputTag("ecalGlobalUncalibRecHit","EcalUncalibRecHitsEB") | ||
| process.caloReco.replace(process.ecalUncalibRecHitSequence, process.ecalUncalibRecHitSequenceHI) |
There was a problem hiding this comment.
shouldn't you also update process.ecalMonitorTask ? (can also check with "hasattr")
This seems the only one missing (based on the prompt reco HI setup)
|
Yes, I had missed the ecalMonitorTask. I added that check and combined RECO,DQM steps run now. |
|
Pull request #12507 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
merge |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
…obalFit_75X add customization to switch to Global ECAL reco from multifit
@slava77 @yetkinyilmaz @ttrk
As discussed in the RECO meeting earlier today, this is a customization that changes the ecal reconstruction method from default multifit to global.
It is not enabled in any workflows, but local testing confirmed that the Global reco was run when the customization was added.
Please advise if this should be forward ported to 76X and 80X.