New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileInPath must handle symbolic links properly #12508
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @wmtan for CMSSW_8_0_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@@ -0,0 +1,13 @@ | |||
#ifndef FWCore_Utilities_ResolveSymbolicLinks_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name of the file to start with a lower case since this isn't a class header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
FileInPath must handle symbolic links properly
This PR fixes FileInPath to work properly in the presence of symbolic links in any relevant paths.
Currently, FileInPath does not resolve symbolic links before checking if paths match. This can cause matches to be missed. Since the IB unit tests are now run with a symbolic link to the src directory,
the FWCore/PythonParameterSet unit test was failing due to this issue. This PR should fix the test.