Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #12523: Small bugfixes in alignment workflows #12526

Merged
merged 4 commits into from Jan 5, 2016

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Nov 20, 2015

  • fix the bug I mentioned in the alignment meeting yesterday in the systematic misalignment tool
    • new geometry comparison for applying "misalignment" with no shift, I think what's left is rounding errors:
      image
  • fix bug that Gregor mentioned last week, of not copying png and pdf files
  • a couple of other minor bugs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_4_X.

It involves the following packages:

Alignment/OfflineValidation
Alignment/TrackerAlignment

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2015

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ghellwig
Copy link

Will this be merged for the next 74X release or is there any unsolved issue?
-Gregor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 5, 2016
Backport of #12523: Small bugfixes in alignment workflows
@cmsbuild cmsbuild merged commit b250067 into cms-sw:CMSSW_7_4_X Jan 5, 2016
@hroskes hroskes deleted the alignment-bugfixes-74X branch January 7, 2016 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants