New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix saveJobReport in DQMFileSaver. #12539
Conversation
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_0_X. It involves the following packages: DQMServices/Components @cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
this should indeed do the trick as discussed in |
+1 |
-1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Now saveJobReport() will only be called if and only if the actual file was saved. This also means the actual filename will be used.
9ed4da1
to
a240303
Compare
Rebased this commit and it now has a proper/common ancestor with the 76x branch. |
please test |
+1 |
The tests are being triggered in jenkins. |
Pull request #12539 was updated. @cmsbuild, @davidlange6 can you please check and sign again. |
please backport to 75 and 76 |
+1 |
Fix saveJobReport in DQMFileSaver.
Now saveJobReport() will only be called if and only if the actual file
was saved. This also means the actual filename will be used.