Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saveJobReport in DQMFileSaver. #12539

Merged
merged 1 commit into from Nov 25, 2015
Merged

Conversation

dmitrijus
Copy link
Contributor

Now saveJobReport() will only be called if and only if the actual file
was saved. This also means the actual filename will be used.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_0_X.

It involves the following packages:

DQMServices/Components

@cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Nov 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9894/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Nov 23, 2015

this should indeed do the trick as discussed in
https://hypernews.cern.ch/HyperNews/CMS/get/dqmDevel/2296.html
@amaltaro

@deguio
Copy link
Contributor

deguio commented Nov 23, 2015

+1

@dmitrijus
Copy link
Contributor Author

-1
please wait until tomorrow before merging, I want to try something out

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Now saveJobReport() will only be called if and only if the actual file
was saved. This also means the actual filename will be used.
@dmitrijus
Copy link
Contributor Author

Rebased this commit and it now has a proper/common ancestor with the 76x branch.
Can be merged!

@deguio
Copy link
Contributor

deguio commented Nov 24, 2015

please test

@deguio
Copy link
Contributor

deguio commented Nov 24, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9917/console

@cmsbuild
Copy link
Contributor

Pull request #12539 was updated. @cmsbuild, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Nov 24, 2015

please backport to 75 and 76

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 25, 2015
Fix saveJobReport in DQMFileSaver.
@cmsbuild cmsbuild merged commit d2d0082 into cms-sw:CMSSW_8_0_X Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants