New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the default output of the statics report #1258
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. change the default output of the statics report It involves the following packages: Utilities/StaticAnalyzers @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
# func += item, | ||
func += "\t"+item, | ||
func += item, | ||
# func += "\t"+item, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not comment code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Chris asked me for several formats to the report and I did not want to retype it every time. Besides this is python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS This is needed to go with the directions I will post to hypernews later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe two separate functions would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what generates the calling functions list. I just put the tabbing there for convenience. I can move the tabbing elsewhere in the code.
Pull request #1258 was updated. @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
Pull request #1258 was updated. @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
Tools update -- Change the default output for statics report.
This changes to default output to
accessing function # static variable # top level function ( analyze, produce, filter )
Previous default was
accessing function # static variable
tabbed list of functions calling accessing function