Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the default output of the statics report #1258

Merged
merged 3 commits into from Nov 1, 2013
Merged

change the default output of the statics report #1258

merged 3 commits into from Nov 1, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 31, 2013

This changes to default output to
accessing function # static variable # top level function ( analyze, produce, filter )

Previous default was

accessing function # static variable
tabbed list of functions calling accessing function

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

change the default output of the statics report

It involves the following packages:

Utilities/StaticAnalyzers

@Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

# func += item,
func += "\t"+item,
func += item,
# func += "\t"+item,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not comment code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Chris asked me for several formats to the report and I did not want to retype it every time. Besides this is python.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS This is needed to go with the directions I will post to hypernews later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe two separate functions would be better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what generates the calling functions list. I just put the tabbing there for convenience. I can move the tabbing elsewhere in the code.

@cmsbuild
Copy link
Contributor

Pull request #1258 was updated. @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1258 was updated. @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2013

ktf added a commit that referenced this pull request Nov 1, 2013
Tools update -- Change the default output for statics report.
@ktf ktf merged commit 6feed1f into cms-sw:CMSSW_7_0_X Nov 1, 2013
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants