Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize sequences for the harvesting modules of PV and V0 validation #12585

Merged

Conversation

makortel
Copy link
Contributor

This PR creates a common sequence to contain the harvesting modules of primary vertex and V0 validation, and that sequence is then added to postValidation sequence. The main motivation for this reorganization is to include postProcessorV0 in postProcessorVertexStandAlone (since the V0 validation is part of vertexValidationStandalone).

Tested in 800pre2, no changes expected.

@rovere @VinInn

This way postProcessorVertexStandalone can be easily modified to
correspond vertexValidationStandalone
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Validation/Configuration
Validation/RecoVertex

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @istaslis, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@VinInn
Copy link
Contributor

VinInn commented Nov 27, 2015

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9983/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Nov 29, 2015

+1

@deguio
Copy link
Contributor

deguio commented Nov 30, 2015

+1

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2015

+1

for #12585 e238a40

  • changes not really affecting reco: mild reorganization of a post-processing sequence
  • jenkins tests pass and comparisons with the baseline show no differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 1, 2015
…cessor

Reorganize sequences for the harvesting modules of PV and V0 validation
@cmsbuild cmsbuild merged commit f42f68d into cms-sw:CMSSW_8_0_X Dec 1, 2015
@makortel makortel deleted the updateVertexValidationPostProcessor branch October 20, 2016 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants