Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use TrackCollection instead of a view of tracks in muon track isolation (same as #12594 ) #12596

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 30, 2015

use TrackCollection instead of a view of tracks in muon track isolation
the view in the end was never really used

this workaround reduces memory consumption of the muon reco code in HI events.

@slava77 slava77 changed the title use TrackCollection instead of a view of tracks in muon track isolation (same as #12594 ) #12595 use TrackCollection instead of a view of tracks in muon track isolation (same as #12594 ) Nov 30, 2015
@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10008/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

RecoMuon/MuonIsolation

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2015

+1

for #12596 b82670f

  • technical change in reading tracks from the event; added in 75X already
  • jenkins tests pass and comparisons with baseline show no difference

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 1, 2015
…onTkIsoNoViews

 use TrackCollection instead of a view of tracks in muon track isolation (same as #12594 )
@cmsbuild cmsbuild merged commit 303f060 into cms-sw:CMSSW_8_0_X Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants