Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for on track cluster plots in Pix DQM for HI runs #12607

Merged
merged 2 commits into from Dec 3, 2015
Merged

Fix for on track cluster plots in Pix DQM for HI runs #12607

merged 2 commits into from Dec 3, 2015

Conversation

fioriNTU
Copy link
Contributor

Insert correct primary vertex and reco tracks label for HI running

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_8_0_X.

It involves the following packages:

DQM/SiPixelCommon
DQM/SiPixelMonitorTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Nov 30, 2015

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2015

@deguio
Copy link
Contributor

deguio commented Dec 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
Fix for on track cluster plots in Pix DQM for HI runs
@cmsbuild cmsbuild merged commit 2c57e35 into cms-sw:CMSSW_8_0_X Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants