Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackedCandidates.. comment out parts of unit test that are not expected to work given that data are packed upon creation with precision loss (same as #12430) #12612

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 30, 2015

backport from 80X to 76X

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Nov 30, 2015
@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10027/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_6_X.

It involves the following packages:

DataFormats/PatCandidates

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Dec 1, 2015

+1

for #12612 24e7650

@slava77
Copy link
Contributor Author

slava77 commented Dec 1, 2015

merge

without this we get unnecessary "noise" in integration tests

cmsbuild added a commit that referenced this pull request Dec 1, 2015
…ixPackedCandidateUnitTests-rebase

PackedCandidates.. comment out parts of unit test that are not expected to work given that data are packed upon creation with precision loss (same as #12430)
@cmsbuild cmsbuild merged commit 574b353 into cms-sw:CMSSW_7_6_X Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants