Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIZeroBias Trigger in Strip DQM #12623

Merged
merged 1 commit into from Dec 3, 2015
Merged

Add HIZeroBias Trigger in Strip DQM #12623

merged 1 commit into from Dec 3, 2015

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Dec 1, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2015

A new Pull Request was created by @fioriNTU for CMSSW_7_5_X.

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@fioriNTU
Copy link
Contributor Author

fioriNTU commented Dec 1, 2015

@davidlange6 it would be great to have this merged in a coming patch release for HI, if possible

@fioriNTU
Copy link
Contributor Author

fioriNTU commented Dec 2, 2015

@deguio @davidlange6 @slava77 sorry to insist, but this is a very basic fix, not touching any c++ code and it will cure the unreasonable high number of reconstructed tracks that show up in Offline DQM plots. Please let me know if it can be merged before HI collisions are over

@davidlange6
Copy link
Contributor

@deguio (and most others) typically gets to things quickly but not always within 1 working day.

On Dec 2, 2015, at 2:06 PM, fioriNTU notifications@github.com wrote:

@deguio @davidlange6 @slava77 sorry to insist, but this is a very basic fix, not touching any c++ code and it will cure the unreasonable high number of reconstructed tracks that show up in Offline DQM plots. Please let me know if it can be merged before HI collisions are over


Reply to this email directly or view it on GitHub.

@slava77
Copy link
Contributor

slava77 commented Dec 2, 2015

@cmsbuild please test
could help to get things moving

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10083/console

@deguio
Copy link
Contributor

deguio commented Dec 2, 2015

+1
in a period during which we receive only urgent request, the urgency mode is the new normality.
don't be surprised if this or some other urgent PR miss the release
cheers,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
Add HIZeroBias Trigger in Strip DQM
@cmsbuild cmsbuild merged commit b298140 into cms-sw:CMSSW_7_5_X Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants