resolve some issues from static analyzer (mostly in RECO)

[slava77]

• clear "using namespace" cases
• nonconst static in a test code in InterpolationDebug (since I didn't find any use cases where it's changing run time)
• MagneticFieldGrid assert the valid range of input grid types to clear reports of possible uninitialized or values used
• mem leak in EndcapPiZeroDiscriminatorAlgo
• some cleanup in Multi5x5BremRecoveryClusterAlgo:
  • assert temp array sizes are above zero (static analyzer can't tell that from a vector::empty() call)
  • const arguments where relevant
  • for auto loops
• some cleanup in ClusterShapeAlgo
  • reduce vector copying
  • for auto loops
• assert valid range in Basic2DGenericPFlowPositionCalc

tested in CMSSW_8_0_X_2015-11-30-1100: no differences in comparisons

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10157/console

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

MagneticField/Interpolation
RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaCoreTools
RecoParticleFlow/PFClusterProducer
Validation/MuonGEMDigis
Validation/MuonGEMRecHits

@cvuosalo, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@namapane, @Sam-Harper, @mmarionncern, @argiro, @lgray, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[cmsbuild]

+1
Tested at: 5f2128f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12676/10157/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12676/10157/summary.html

[deguio]

+1

[slava77]

+1

for #12676 5f2128f

• jenkins tests confirmed no changes in monitored quantities

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1