-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tracking validation sequences to prevalidation #12688
Move tracking validation sequences to prevalidation #12688
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X. It involves the following packages: FastSimulation/Validation @civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
…"prevalidation" sequence We don't use TriggerResults, so there is no need for these modules to be in EndPath.
72655ec
to
9e1974e
Compare
Pull request #12688 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
Thanks @lveldere, I took the FastSim modifications out (this time by editing the commit). |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Move tracking validation sequences to prevalidation
This PR is a follow-up to @deguio's comment #12542 (comment). Nothing in track+vertex validation depends on TriggerResults, so all modules are moved to the prevalidation sequence (to be run in a regular Path instead of EndPath).
Tested in CMSSW_8_0_X_2015-12-06-1100, no changes expected.
@rovere @VinInn