Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracking validation sequences to prevalidation #12688

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 7, 2015

This PR is a follow-up to @deguio's comment #12542 (comment). Nothing in track+vertex validation depends on TriggerResults, so all modules are moved to the prevalidation sequence (to be run in a regular Path instead of EndPath).

Tested in CMSSW_8_0_X_2015-12-06-1100, no changes expected.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Validation
HLTriggerOffline/Common
Validation/Configuration
Validation/RecoTrack

@civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@istaslis, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @wmtford, @matt-komm, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@lveldere
Copy link
Contributor

lveldere commented Dec 7, 2015

@makortel

Please leave the fastsim globalValidation_cff unchanged.
Once #12642 is merged, changes to the standard globalValidation_cff will automatically propagate to fastsim.

…"prevalidation" sequence

We don't use TriggerResults, so there is no need for these modules to be in EndPath.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

Pull request #12688 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Dec 7, 2015

Thanks @lveldere, I took the FastSim modifications out (this time by editing the commit).

@slava77
Copy link
Contributor

slava77 commented Dec 7, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10185/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

@slava77
Copy link
Contributor

slava77 commented Dec 7, 2015

+1

for #12688 9e1974e

  • updates are in line with the PR description; reco is not affected
  • jenkins tests pass and comparisons with baseline show no differences.

@civanch
Copy link
Contributor

civanch commented Dec 8, 2015

+1

@deguio
Copy link
Contributor

deguio commented Dec 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Dec 9, 2015
Move tracking validation sequences to prevalidation
@davidlange6 davidlange6 merged commit 7b3dbbe into cms-sw:CMSSW_8_0_X Dec 9, 2015
@makortel makortel deleted the trkValidationReorganizeSequences branch October 20, 2016 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants