Fastsim: use fastsim era in global validation #12642

lveldere · 2015-12-02T14:39:16Z

The fastsim era is used to apply fastsim mods to globalValidation_cff.py
The fastsim era is used to apply fastsim mods to post validation
Other validation sequences and the DQM sequence will follow

…on configuration

cmsbuild · 2015-12-02T14:39:39Z

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
FastSimulation/Configuration
FastSimulation/Validation
SimGeneral/TrackingAnalysis
SimMuon/MCTruth
Validation/Configuration
Validation/DTRecHits
Validation/EcalDigis
Validation/EcalHits
Validation/EcalRecHits
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits
Validation/MuonCSCDigis
Validation/MuonDTDigis
Validation/MuonHits
Validation/MuonIdentification
Validation/MuonRPCDigis
Validation/RPCRecHits
Validation/RecoEgamma
Validation/RecoMuon

@civanch, @lveldere, @cvuosalo, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @ssekmen, @srimanob, @deguio, @slava77, @vanbesien, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @Martin-Grunewald, @richard-cms, @rovere, @matt-komm, @cerati, @argiro, @trocino, @dgulhan, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

lveldere · 2015-12-02T14:40:44Z

please test

cmsbuild · 2015-12-02T14:41:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10092/console

cmsbuild · 2015-12-02T19:15:22Z

+1
Tested at: f055fe9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12642/10092/summary.html

cmsbuild · 2015-12-02T20:13:11Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12642/10092/summary.html

lveldere · 2015-12-03T06:58:22Z

+1

the only relevant changes are in the fastsim generator directory.
these changes are expected: this pr introduces proper post validation in this directory for fastsim.

slava77 · 2015-12-03T07:08:06Z

+1

for #12642 f055fe9

changes in the code are in line with the description
jenkins tests pass. In comparisons with the baseline there are no changes in reco product quantities; in the DQM plots, only in the /Generator/ directory there are changes which look like just a removal of the relative normalization of the plots

civanch · 2015-12-03T08:55:36Z

+1

deguio · 2015-12-07T10:00:40Z

+1
changes makes sense to me.

lveldere · 2015-12-08T10:35:05Z

operations, pdmv

Would you mind reviewing?
Please let me know if there are any comments or questions.

srimanob · 2015-12-08T10:58:20Z

+1
For PdmV, only change in havesting step.

Fastsim: use fastsim era in global validation

acaudron · 2016-02-26T16:08:56Z

@lveldere
Sorry to arrive late on this but we realised (thanks to @swertz @pablodecm) one thing recently due to this PR: in the relval validation for the b-tagging plots, some of them disappear for fastsim. This due to the fact we are not running exactly the same sequence on fast and fullsim as some plots for fullsim are produced by the DQMOffline sequence. In fastsim we modified the sequence to also produced these plots as the DQMOffline one is not ran.

Basically you removed this sequence:
https://github.com/cms-sw/cmssw/pull/12642/files#diff-2a5bcde0d120eb3959a5690f13018de7L42
and then you did this change:
https://github.com/cms-sw/cmssw/pull/12642/files#diff-280a22a34e1b642031a67e76fefd1e28R96
which implies now the sequence is the same for full and fastsim for b-tagging as now it will take for fastsim:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/Validation/Configuration/python/globalValidation_cff.py#L89

So basically in your "if" for FastSim you need to have a replace (or a remove and add) to run the proper b-tagging validation sequence. We have a similar issue for the postvalidation sequence due to this change:
https://github.com/cms-sw/cmssw/pull/12642/files#diff-819af2ec677272fddf1fef50e788a88bR1242

So basically, we would appreciate if it can be fixed soon. Let say that there are not the most important plots but we would still appreciate to be able to monitor them.

Thanks

lveldere · 2016-02-26T16:16:34Z

Hi Adrien

Thanks for reporting.
Now it makes sense.
I'll look into it next week.

Cheers

Lukas

On Fri, Feb 26, 2016 at 5:09 PM, acaudron notifications@github.com wrote:

@lveldere https://github.com/lveldere
Sorry to arrive late on this but we realised (thanks to @swertz
https://github.com/swertz @pablodecm https://github.com/pablodecm)
one thing recently due to this PR: in the relval validation for the
b-tagging plots, some of them disappear for fastsim. This due to the fact
we are not running exactly the same sequence on fast and fullsim as some
plots for fullsim are produced by the DQMOffline sequence. In fastsim we
modified the sequence to also produced these plots as the DQMOffline one is
not ran.

Basically you removed this sequence:

https://github.com/cms-sw/cmssw/pull/12642/files#diff-2a5bcde0d120eb3959a5690f13018de7L42
and then you did this change:

https://github.com/cms-sw/cmssw/pull/12642/files#diff-280a22a34e1b642031a67e76fefd1e28R96
which implies now the sequence is the same for full and fastsim for
b-tagging as now it will take for fastsim:

https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/Validation/Configuration/python/globalValidation_cff.py#L89

So basically in your "if" for FastSim you need to have a replace (or a
remove and add) to run the proper b-tagging validation sequence. We have a
similar issue for the postvalidation sequence due to this change:

https://github.com/cms-sw/cmssw/pull/12642/files#diff-819af2ec677272fddf1fef50e788a88bR1242

So basically, we would appreciate if it can be fixed soon. Let say that
there are not the most important plots but we would still appreciate to be
able to monitor them.

Thanks

—
Reply to this email directly or view it on GitHub
#12642 (comment).

lveldere · 2016-02-29T15:14:38Z

HI Adrien

Can you point me to the FullSim configuration for b-tag DQM?
In which path is it run?

VALIDATION:@standardValidation
VALIDATION:@miniAODValidation
DQM:@standardDQM
DQM:@miniAODDQM

At the moment FastSim runs a version of VALIDATION:@standardValidation
and soon FastSim will run a modified version of DQM:@standardDQM

Thanks

Lukas

On Fri, Feb 26, 2016 at 5:16 PM, Lukas Vanelderen <lukasvanelderen@gmail.com

wrote:

Hi Adrien

Thanks for reporting.
Now it makes sense.
I'll look into it next week.

Cheers

Lukas

On Fri, Feb 26, 2016 at 5:09 PM, acaudron notifications@github.com
wrote:

@lveldere https://github.com/lveldere
Sorry to arrive late on this but we realised (thanks to @swertz
https://github.com/swertz @pablodecm https://github.com/pablodecm)
one thing recently due to this PR: in the relval validation for the
b-tagging plots, some of them disappear for fastsim. This due to the fact
we are not running exactly the same sequence on fast and fullsim as some
plots for fullsim are produced by the DQMOffline sequence. In fastsim we
modified the sequence to also produced these plots as the DQMOffline one is
not ran.

Basically you removed this sequence:

https://github.com/cms-sw/cmssw/pull/12642/files#diff-2a5bcde0d120eb3959a5690f13018de7L42
and then you did this change:

https://github.com/cms-sw/cmssw/pull/12642/files#diff-280a22a34e1b642031a67e76fefd1e28R96
which implies now the sequence is the same for full and fastsim for
b-tagging as now it will take for fastsim:

https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/Validation/Configuration/python/globalValidation_cff.py#L89

So basically in your "if" for FastSim you need to have a replace (or a
remove and add) to run the proper b-tagging validation sequence. We have a
similar issue for the postvalidation sequence due to this change:

https://github.com/cms-sw/cmssw/pull/12642/files#diff-819af2ec677272fddf1fef50e788a88bR1242

So basically, we would appreciate if it can be fixed soon. Let say that
there are not the most important plots but we would still appreciate to be
able to monitor them.

Thanks

—
Reply to this email directly or view it on GitHub
#12642 (comment).

Lukas added 8 commits December 2, 2015 15:17

got rid of needless fastsim sequences in muon and photon postValidati…

978f444

…on configuration

intermediate commit

d061073

global validation and postvalidation: use fastsim era for fatsim customs

3259089

remove typo in comment

3c22f36

remove obsolete file

3c106b9

fix typo

cc5040b

fix typo

bd3f0a9

fix bad merge

f055fe9

cmsbuild added this to the Next CMSSW_8_0_X milestone Dec 2, 2015

cmsbuild added reconstruction-pending simulation-pending dqm-pending fastsim-pending operations-pending pending-signatures tests-pending orp-pending comparison-pending pdmv-pending labels Dec 2, 2015

lveldere mentioned this pull request Dec 2, 2015

Fastsim era global validation2 #12460

Closed

cmsbuild added tests-started and removed tests-pending labels Dec 2, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 2, 2015

cmsbuild removed the comparison-pending label Dec 2, 2015

cmsbuild added the comparison-available label Dec 2, 2015

cmsbuild added fastsim-approved and removed fastsim-pending labels Dec 3, 2015

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 3, 2015

cmsbuild added simulation-approved and removed simulation-pending labels Dec 3, 2015

cmsbuild added dqm-approved and removed dqm-pending labels Dec 7, 2015

lveldere mentioned this pull request Dec 7, 2015

Move tracking validation sequences to prevalidation #12688

Merged

cmsbuild added pdmv-approved and removed pdmv-pending labels Dec 8, 2015

davidlange6 added a commit that referenced this pull request Dec 9, 2015

Merge pull request #12642 from lveldere/fastsim-era-globalValidation2

9e48c0d

Fastsim: use fastsim era in global validation

davidlange6 merged commit 9e48c0d into cms-sw:CMSSW_8_0_X Dec 9, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fastsim: use fastsim era in global validation #12642

Fastsim: use fastsim era in global validation #12642

lveldere commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

lveldere commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

lveldere commented Dec 3, 2015

slava77 commented Dec 3, 2015

civanch commented Dec 3, 2015

deguio commented Dec 7, 2015

lveldere commented Dec 8, 2015

srimanob commented Dec 8, 2015

acaudron commented Feb 26, 2016

lveldere commented Feb 26, 2016

lveldere commented Feb 29, 2016

Fastsim: use fastsim era in global validation #12642

Fastsim: use fastsim era in global validation #12642

Conversation

lveldere commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

lveldere commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

cmsbuild commented Dec 2, 2015

lveldere commented Dec 3, 2015

slava77 commented Dec 3, 2015

civanch commented Dec 3, 2015

deguio commented Dec 7, 2015

lveldere commented Dec 8, 2015

srimanob commented Dec 8, 2015

acaudron commented Feb 26, 2016

lveldere commented Feb 26, 2016

lveldere commented Feb 29, 2016