Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new miniAOD-only workflows for miniAOD validation #12720

Merged
merged 24 commits into from Feb 23, 2016

Conversation

hengne
Copy link
Contributor

@hengne hengne commented Dec 9, 2015

1.) Add miniAOD-only relval workflows running only the miniAOD+DQM step (also harvest step) using previous RECO/AOD as input.
2.) For all major Run2 fullSim noPU, PU, and 2015 data workflows, the corresponding miniAOD-only workflows are created.
3.) For 2015 data miniAOD-only workflows, add some protections in the customization functions. Those customization functions try to modify some parameters that not used and do not exist in the miniAOD only configuration file, so without a protection to check the existence of the parameters, the workflows will fail to run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

A new Pull Request was created by @hengne (Hengne Li) for CMSSW_7_6_X.

It involves the following packages:

Configuration/DataProcessing
Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@hengne
Copy link
Contributor Author

hengne commented Dec 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10210/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

@cmsbuild
Copy link
Contributor

Pull request #12720 was updated. @boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please check and sign again.

@hengne
Copy link
Contributor Author

hengne commented Dec 11, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10255/console

@fabozzi
Copy link
Contributor

fabozzi commented Dec 11, 2015

@hengne
I agree with your plan to restore autoCond GT in 80X

@cmsbuild
Copy link
Contributor

-1
Tested at: 57041c8
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12720/10255/summary.html

@hengne
Copy link
Contributor Author

hengne commented Dec 12, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10270/console

@cmsbuild
Copy link
Contributor

@srimanob
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Feb 23, 2016
new miniAOD-only workflows for miniAOD validation
@davidlange6 davidlange6 merged commit 98c32a7 into cms-sw:CMSSW_7_6_X Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants