Add PoolSource parameter to specify run number for each lumi #12753

wmtan · 2015-12-10T22:48:58Z

This PR implements a new parameter "setRunNumberForEachLumi" for PoolSource, which allows a user to specify a new run number for each consecutive lumi in a single run in the simulation input. The run may be split across multiple input files. There must be at least as many entries in the parameter as the number of lumis that are read.
Unit tests for this feature are also implemented.
While implementing this new parameter, I made four synergistic improvements not directly related to the new feature:

The function ThinnedAssociationsHelper:updateFromInput was actually two different unrelated functions cobbled together in a suboptimal way that resulted in the need to pass unused arguments in some cases. So, I refactored this function into two much cleaner functions.
I also added two new delegating constructors for class RootFIle.
I also eliminated the need for constructing dummy arguments fo the RootFile constructors by using pointers instead of references, so that nullptr could be used instead of a default constructed dummy.
I put the use of the two parameters that renumber runs into a helper class using the strategy pattern.

cmsbuild · 2015-12-10T22:49:20Z

A new Pull Request was created by @wmtan for CMSSW_8_0_X.

It involves the following packages:

DataFormats/Provenance
IOPool/Input
IOPool/Streamer

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

Dr15Jones · 2015-12-11T12:49:37Z

Please test

cmsbuild · 2015-12-11T12:49:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10260/console

cmsbuild · 2015-12-11T15:39:42Z

+1
Tested at: 9e16b46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12753/10260/summary.html

cmsbuild · 2015-12-11T16:34:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12753/10260/summary.html

Dr15Jones · 2015-12-15T14:59:43Z

IOPool/Input/src/PoolSource.cc

@@ -319,6 +365,8 @@ namespace edm {
        ->setComment("Size of ROOT TTree TBasket cache. Affects performance.");
    desc.addUntracked<unsigned int>("setRunNumber", 0U)
        ->setComment("If non-zero, change number of first run to this number. Apply same offset to all runs. Allowed only for simulation.");
+    desc.addUntracked<std::vector<unsigned int> >("setRunNumberForEachLumi", std::vector<unsigned int>())


Talk with David Dagenhart about how to specify that this new parameter and the setRun can not be used simultaneously.

There already is such protection, but I will talk with David to see if this protection can be done in the descriptions instead.

Yes, this protection can be done in the descriptions. Will do.

cmsbuild · 2015-12-18T16:33:44Z

Pull request #12753 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

wmtan · 2015-12-18T16:36:58Z

@Dr15Jones This PR has been redone using a strategy pattern to encapsulate the new (and some old) functionality to enhance maintainability, as per a suggestion from Chris Jones.

cmsbuild · 2015-12-18T18:47:47Z

Pull request #12753 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

wmtan · 2015-12-18T18:49:13Z

Corrected a minor typo.

wmtan · 2015-12-18T18:49:34Z

@cmsbuild please test

cmsbuild · 2015-12-18T18:49:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10359/console

cmsbuild · 2015-12-18T20:44:33Z

+1
Tested at: 06ad69d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12753/10359/summary.html

cmsbuild · 2015-12-18T21:35:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12753/10359/summary.html

Dr15Jones · 2015-12-22T15:18:06Z

+1

cmsbuild · 2015-12-22T15:18:24Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Add PoolSource parameter to specify run number for each lumi

cmsbuild added this to the Next CMSSW_8_0_X milestone Dec 10, 2015

cmsbuild added core-pending pending-signatures tests-pending orp-pending comparison-pending labels Dec 10, 2015

wmtan changed the title ~~Add PoolSOurce parameter to specify run number for each lumi~~ Add PoolSource parameter to specify run number for each lumi Dec 10, 2015

wmtan mentioned this pull request Dec 11, 2015

Allow PoolSource to modify the run number on each luminosity block to support run dependent MC #12233

Closed

cmsbuild added tests-started and removed tests-pending labels Dec 11, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 11, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 11, 2015

Dr15Jones reviewed Dec 15, 2015
View reviewed changes

wmtan force-pushed the SpecifyRunNumberForEachLumi branch from 9e16b46 to 0a7fee8 Compare December 18, 2015 16:33

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Dec 18, 2015

Specify run number for each lumi

06ad69d

wmtan force-pushed the SpecifyRunNumberForEachLumi branch from 0a7fee8 to 06ad69d Compare December 18, 2015 18:47

cmsbuild added tests-started and removed tests-pending labels Dec 18, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 18, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 18, 2015

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Dec 22, 2015

davidlange6 added a commit that referenced this pull request Dec 23, 2015

Merge pull request #12753 from wmtan/SpecifyRunNumberForEachLumi

9c253b5

Add PoolSource parameter to specify run number for each lumi

davidlange6 merged commit 9c253b5 into cms-sw:CMSSW_8_0_X Dec 23, 2015

wmtan deleted the SpecifyRunNumberForEachLumi branch February 5, 2016 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PoolSource parameter to specify run number for each lumi #12753

Add PoolSource parameter to specify run number for each lumi #12753

wmtan commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

Dr15Jones commented Dec 11, 2015

cmsbuild commented Dec 11, 2015

cmsbuild commented Dec 11, 2015

cmsbuild commented Dec 11, 2015

Dr15Jones Dec 15, 2015

wmtan Dec 15, 2015

wmtan Dec 15, 2015

cmsbuild commented Dec 18, 2015

wmtan commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

wmtan commented Dec 18, 2015

wmtan commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

Dr15Jones commented Dec 22, 2015

cmsbuild commented Dec 22, 2015

Add PoolSource parameter to specify run number for each lumi #12753

Add PoolSource parameter to specify run number for each lumi #12753

Conversation

wmtan commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

Dr15Jones commented Dec 11, 2015

cmsbuild commented Dec 11, 2015

cmsbuild commented Dec 11, 2015

cmsbuild commented Dec 11, 2015

Dr15Jones Dec 15, 2015

Choose a reason for hiding this comment

wmtan Dec 15, 2015

Choose a reason for hiding this comment

wmtan Dec 15, 2015

Choose a reason for hiding this comment

cmsbuild commented Dec 18, 2015

wmtan commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

wmtan commented Dec 18, 2015

wmtan commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

Dr15Jones commented Dec 22, 2015

cmsbuild commented Dec 22, 2015