Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix putting output stream into output stream #12756

Merged
merged 1 commit into from Dec 15, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Dec 11, 2015

Putting output stream into output stream (e.g. std::cout << std::cout)
was fixed in C++11 as it now allowed. This is now enforced by GCC 5.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Putting output stream into output stream (e.g. `std::cout << std::cout`)
was fixed in C++11 as it now allowed. This is now enforced by GCC 5.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_8_0_X.

It involves the following packages:

SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@davidlt
Copy link
Contributor Author

davidlt commented Dec 11, 2015

Note, that tests are already running.

@cmsbuild
Copy link
Contributor

-1

Tested at: 7e13055
I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12756/10258/summary.html

@cmsbuild
Copy link
Contributor

@davidlt
Copy link
Contributor Author

davidlt commented Dec 11, 2015

Failure not related to the unit test.

davidlange6 added a commit that referenced this pull request Dec 15, 2015
Fix putting output stream into output stream
@davidlange6 davidlange6 merged commit 1a95cb6 into cms-sw:CMSSW_8_0_X Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants