Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SiStripErrors in HI repacking (porting PR #12674) #12762

Merged
merged 2 commits into from Dec 15, 2015

Conversation

abaty
Copy link
Contributor

@abaty abaty commented Dec 11, 2015

This is a port of PR #12674 into 8_0_X . Used for fixing the heavy ion repacking that is run in the HLT for the SiStrips. Also needed to store SiStrip error info is on disk and show it in the DQM.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abaty for CMSSW_8_0_X.

It involves the following packages:

Configuration/StandardSequences
EventFilter/SiStripRawToDigi

@cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Dec 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10265/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Dec 14, 2015

+1

for #12762 b80189e

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 15, 2015
Fix for SiStripErrors in HI repacking (porting PR #12674)
@cmsbuild cmsbuild merged commit 313aba8 into cms-sw:CMSSW_8_0_X Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants