Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PythiaMomDauFilter filter 20151218 #12827

Merged

Conversation

taweiXcms
Copy link
Contributor

Add and fix PythiaMomDauFilter from 80X

@mandrenguyen, @yenjie, @ginnocen

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @taweiXcms (tawei) for CMSSW_7_5_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@taweiXcms
Copy link
Contributor Author

Dear contacts/managers,
This is a PR of a filter that is needed for the D0/D* PbPb MC generation.
pp group are using the same filter.
Could you have a look and let us know if we are missing anything?
Thank you for your help.

@govoni
Copy link
Contributor

govoni commented Jan 3, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10416/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2016

@taweiXcms
Copy link
Contributor Author

Dear contacts.

Could you please have a quick at this PR and see what's needed to get into next stage?
It's been pending for a few weeks.
We really appreciate your help.
Thank you.

@yenjie, @ginnocen

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 27, 2016
…151218

Add PythiaMomDauFilter filter 20151218
@cmsbuild cmsbuild merged commit 07edda1 into cms-sw:CMSSW_7_5_X Jan 27, 2016
cmsbuild added a commit that referenced this pull request Jan 27, 2016
cmsbuild added a commit that referenced this pull request Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants