New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcx59New Expand Hcal DetId replacing Run2-hcx29 (11427), Run2-hcx48 (12406) and Run2-hcx58 (12726) #12829
Conversation
…d Run2-hcx58 (12726)
A new Pull Request was created by @bsunanda for CMSSW_8_0_X. It involves the following packages: CalibCalorimetry/CaloMiscalibTools @civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @deguio, @slava77, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild Please test |
The tests are being triggered in jenkins. |
@@ -6,6 +6,7 @@ | |||
#include "Geometry/Records/interface/HcalRecNumberingRecord.h" | |||
|
|||
#include <iostream> | |||
using namespace std; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed
The tests are being triggered in jenkins. |
@bsunanda please clarify which tests you have run to do the check at the digitizer? |
I see something similar to the previous iteration This may all be coming from HF (that's unless the plotter HcalDigiMonitor is buggy itself) |
@slava77 I looked at 25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT. I shall look now in 25202. Thanks From: Slava Krutelyov [notifications@github.com] I see something similar to the previous iteration This may all be coming from HF (that's unless the plotter HcalDigiMonitor is buggy itself) — |
The issue is visible only in workflows with pileup. 25.0 doesn't have any. |
@slava77 I tried with 25202 and there too I saw all hits input to HcalDigitizer have new format. In any case if there is some with old ones they can be changed to new format in the digitizaer code. From: Slava Krutelyov [notifications@github.com] The issue is visible only in workflows with pileup. 25.0 doesn't have any. — |
On 12/31/15 4:58 AM, bsunanda wrote:
Just to be sure, were they the same for HF?
|
Yes it is. It is for all hcal subdetectors: hb, he, ho and hf Sent from Samsung Mobile Slava Krutelyov notifications@github.com wrote:
Just to be sure, were they the same for HF?
— |
@bsunanda |
here come merge conflicts |
-1 |
Expand Hcal DetId (supersedes #12829)
Trying to use data model evolution capability for HcalDetId