thread safety statics work

[gartung]

Various arrays of constants set and then assigned to other arrays of constants.
Make the static arrays const for thread safety.
Make the arrays these are copied to const.

[gartung]

@Dr15Jones can you take a look.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

thread safety statics work

It involves the following packages:

L1Trigger/CSCTrackFinder

@nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[Dr15Jones]

It appears that the arrays were just changed to const. If so, that is definitely thread safe.

[gartung]

In the main body of the code, I had to change double to const double in the initialization statements. I also had to change the variables the array were copied/assigned to from double to const double.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1138/summary.html

[ktf]

Maybe I'm sleep deprived, but shouldn't this simply remove the variables? Who sets those variables?

[gartung]

The static arrays are copied to other arrays multiple times. Not sure why they wanted static as the savings in memory can't be that much.

[ktf]

Nevermind. It's indeed sleep deprivation… I did not notice the arrays were initialised in the CC...