Remove PHcalParameters and provide new GT for all scenarios. #12832

diguida · 2015-12-18T21:24:16Z

Summary of code changes

Remove PHcalParameters class, which is replaced by HcalParameters. Originally in #12817

Summary of GT Changes

RunI Simulation

Ideal scenario: 80X_mcRun1_design_v0: As 76X_mcRun1_design_v11 with the following changes:
- removed PHcalParametersRcd.
Realistic scenario: 80X_mcRun1_realistic_v0: As 76X_mcRun1_realistic_v11 with the following changes:
- removed PHcalParametersRcd.
Heavy Ion scenario: 80X_mcRun1_HeavyIon_v0: As 76X_mcRun1_HeavyIon_v11 with the following changes:
- removed PHcalParametersRcd.
Proton-Lead scenario: 80X_mcRun1_pA_v0: As 76X_mcRun1_pA_v11 with the following changes:
- removed PHcalParametersRcd.

RunII Simulation

Ideal scenario: 80X_mcRun2_design_v0: As 76X_mcRun2_design_v14 with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
- removed PHcalParametersRcd.
Startup scenario: 80X_mcRun2_startup_v0: As 76X_mcRun2_startup_v13 with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
- removed PHcalParametersRcd.
Asymptotic scenario: 80X_mcRun2_asymptotic_v0: As 76X_mcRun2_asymptotic_v14 with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
- removed PHcalParametersRcd.
Heavy Ion scenario: 80X_mcRun2_HeavyIon_v0: As 76X_mcRun2_HeavyIon_v14 with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
- removed PHcalParametersRcd.

RunII Data

HLT processing: 80X_dataRun2_HLT_frozen_v0: As 76X_dataRun2_HLT_frozen_v11 (snapshot time set to 2015-12-18 17:00:00 UTC) with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type.
HLT Heavy Ion processing: 80X_dataRun2_HLTHI_frozen_v0: As 76X_dataRun2_HLTHI_frozen_v2 (snapshot time set to 2015-12-18 17:00:00 UTC) with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
Offline processing: 80X_dataRun2_v1: As 80X_dataRun2_v0 with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
- removed PHcalParametersRcd
- updated B tag discriminators for HLT with the following taggers: CombinedSVIVFV2RecoVertex, CombinedSVIVFV2PseudoVertex, CombinedSVIVFV2NoVertex, CombinedSVRecoVertex, CombinedSVPseudoVertex, CombinedSVNoVertex (as used by HLT data collection in 2015).

Upgrade 2017 Simulation

Ideal scenario: 80X_upgrade2017_design_v0: As 76X_upgrade2017_design_v9 with the following changes:
- added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type
- removed PHcalParametersRcd.

cmsbuild · 2015-12-18T21:24:38Z

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_8_0_X.

It involves the following packages:

CondCore/GeometryPlugins
CondCore/Utilities
CondFormats/GeometryObjects
Configuration/AlCa
Geometry/Records

@civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

diguida · 2015-12-18T21:27:04Z

please test

cmsbuild · 2015-12-18T21:27:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10362/console

cmsbuild · 2015-12-18T23:16:32Z

-1
Tested at: e87e9bf
When I ran the RelVals I found an error in the following worklfows:
134.911 step2

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log
----- Begin Fatal Exception 18-Dec-2015 23:03:39 CET-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 256677
   [1] Running path 'HLT_AK8PFJet360_TrimMass30_v3'
   [2] Calling beginRun for module PFProducer/'hltParticleFlow'
Exception Message:
No data of type "PerformancePayload" with label "HLT" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12832/10362/summary.html

mmusich · 2015-12-19T13:23:15Z

Configuration/AlCa/python/autoCond.py

    # GlobalTag for Run2 HLT: it points to the online GT
-    'run2_hlt'          :   '76X_dataRun2_HLT_frozen_v10',
+    'run2_hlt'          :   '76X_dataRun2_HLT_frozen_v0',


@diguida I guess you meant here 80X_dataRun2_HLT_frozen_v0 instead.... the diff looks good CondDB browers

Yeap :-( A typo is always bad: fixing :-)

RunI Simulation * **Ideal scenario**: 80X_mcRun1_design_v0: As 76X_mcRun1_design_v11 with the following changes: * removed PHcalParametersRcd. * **Realistic scenario**: 80X_mcRun1_realistic_v0: As 76X_mcRun1_realistic_v11 with the following changes: * removed PHcalParametersRcd. * **Heavy Ion scenario**: As 76X_mcRun1_HeavyIon_v11 with the following changes: * removed PHcalParametersRcd. * **Proton-Lead scenario**: As 76X_mcRun1_pA_v11 with the following changes: * removed PHcalParametersRcd. RunII Simulation * **Ideal scenario**: As 76X_mcRun2_design_v14 with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * removed PHcalParametersRcd. * **Startup scenario**: As 76X_mcRun2_startup_v13 with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * removed PHcalParametersRcd. * **Asymptotic scenario**: As 76X_mcRun2_asymptotic_v14 with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * removed PHcalParametersRcd. * **Heavy Ion scenario**: As 76X_mcRun2_HeavyIon_v14 with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * removed PHcalParametersRcd. RunII Data * **HLT processing**: 80X_dataRun2_HLT_frozen_v0: As 76X_dataRun2_HLT_frozen_v11 (snapshot time set to 2015-12-18 17:00:00 UTC) with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type. * **HLT Heavy Ion processing**: 80X_dataRun2_HLTHI_frozen_v0: As 76X_dataRun2_HLTHI_frozen_v2 (snapshot time set to 2015-12-18 17:00:00 UTC) with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * **Offline processing**: 80X_dataRun2_v1: As 80X_dataRun2_v0 with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * removed PHcalParametersRcd * updated B tag discriminators for HLT with the following taggers: CombinedSVIVFV2RecoVertex, CombinedSVIVFV2PseudoVertex, CombinedSVIVFV2NoVertex, CombinedSVRecoVertex, CombinedSVPseudoVertex, CombinedSVNoVertex (as used by HLT data collection in 2015). Upgrade 2017 Simulation * **Ideal scenario**: 80X_upgrade2017_design_v0: As 76X_upgrade2017_design_v9 with the following changes: * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type * removed PHcalParametersRcd.

cmsbuild · 2015-12-19T18:08:56Z

Pull request #12832 was updated. @civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

diguida · 2015-12-19T18:09:07Z

please test

cmsbuild · 2015-12-19T18:09:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10363/console

cmsbuild · 2015-12-19T20:05:44Z

+1
Tested at: ba8e231
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12832/10363/summary.html

cmsbuild · 2015-12-19T20:56:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12832/10363/summary.html

diguida · 2015-12-19T21:29:19Z

+1

ianna · 2015-12-20T07:47:14Z

+1

…nd_80X_v0 Remove PHcalParameters and provide new GT for all scenarios.

Remove PHcalParameters which is replaced by HcalParameters

055773f

cmsbuild added this to the Next CMSSW_8_0_X milestone Dec 18, 2015

cmsbuild added alca-pending db-pending geometry-pending pending-signatures tests-pending orp-pending comparison-pending labels Dec 18, 2015

diguida mentioned this pull request Dec 18, 2015

Remove PHcal Parameters #12817

Closed

diguida changed the title ~~Remove PHcal Parameters and provide new GT for all scenarios.~~ Remove PHcalParameters and provide new GT for all scenarios. Dec 18, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 18, 2015

cmsbuild added tests-rejected and removed tests-started labels Dec 18, 2015

mmusich reviewed Dec 19, 2015
View reviewed changes

diguida force-pushed the phcal-parameters-remove_autoCond_80X_v0 branch from e87e9bf to ba8e231 Compare December 19, 2015 18:08

cmsbuild added tests-pending and removed tests-rejected labels Dec 19, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 19, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 19, 2015

cmsbuild added alca-approved and removed alca-pending labels Dec 19, 2015

cmsbuild added geometry-approved and removed geometry-pending labels Dec 20, 2015

davidlange6 added a commit that referenced this pull request Jan 1, 2016

Merge pull request #12832 from diguida/phcal-parameters-remove_autoCo…

2563330

…nd_80X_v0 Remove PHcalParameters and provide new GT for all scenarios.

davidlange6 merged commit 2563330 into cms-sw:CMSSW_8_0_X Jan 1, 2016

mmusich mentioned this pull request Jan 8, 2016

Fixing GTs for Run1 workflows to contain conditions for HcalQIETypes #12892

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove PHcalParameters and provide new GT for all scenarios. #12832

Remove PHcalParameters and provide new GT for all scenarios. #12832

diguida commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

diguida commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

mmusich Dec 19, 2015

diguida Dec 19, 2015

cmsbuild commented Dec 19, 2015

diguida commented Dec 19, 2015

cmsbuild commented Dec 19, 2015

cmsbuild commented Dec 19, 2015

cmsbuild commented Dec 19, 2015

diguida commented Dec 19, 2015

ianna commented Dec 20, 2015

Remove PHcalParameters and provide new GT for all scenarios. #12832

Remove PHcalParameters and provide new GT for all scenarios. #12832

Conversation

diguida commented Dec 18, 2015

Summary of code changes

Summary of GT Changes

RunI Simulation

RunII Simulation

RunII Data

Upgrade 2017 Simulation

cmsbuild commented Dec 18, 2015

diguida commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

cmsbuild commented Dec 18, 2015

mmusich Dec 19, 2015

Choose a reason for hiding this comment

diguida Dec 19, 2015

Choose a reason for hiding this comment

cmsbuild commented Dec 19, 2015

diguida commented Dec 19, 2015

cmsbuild commented Dec 19, 2015

cmsbuild commented Dec 19, 2015

cmsbuild commented Dec 19, 2015

diguida commented Dec 19, 2015

ianna commented Dec 20, 2015