Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set phase1 track algorithms properly #12834

Merged
merged 4 commits into from Dec 23, 2015

Conversation

makortel
Copy link
Contributor

This PR sets the phase1-specific track algos properly in the Phase1PU70 and Phase1PU140 tracking configurations.

Following migrations are included (should cover everything except tracking validation and DQM):

  • The use of track algos in PF is migrated. The initial guess is to treat the new quadruplet iterations as the (current) triplet iterations. @bachtis @arizzi @gpetruc feel free to double-check.
  • LhcTrackAnalyzer is supposedly not used, and is thus modified to throw if it encounters a track with phase1-specific algo, as agreed with alignment (@tlampen @mschrode).
  • AdHocNtupler was straightforward to migrate.

Tracking validation and DQM will be migrated separately (need the phase1 era for that, see e.g. #12806).

Tested in 8_0_0_pre4, no changes expected in Run2 workflows.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Alignment/HIPAlignmentAlgorithm
PhysicsTools/UtilAlgos
RecoParticleFlow/PFTracking
RecoTracker/IterativeTracking

@diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @franzoni, @slava77, @vadler, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @GiacomoSguazzoni, @tocheng, @VinInn, @mschrode, @rovere, @cerati, @gpetruc, @istaslis, @lgray, @dgulhan, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@diguida
Copy link
Contributor

diguida commented Dec 21, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10367/console

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Dec 21, 2015

+1
minimal change in LhcTrackAnalyzer pending overall re-thinking of alignment package for phase-I

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Dec 22, 2015

+1

for #12834 971a1a0

  • changes in the code are as described
  • jenkins tests pass and comparisons with the baseline show no differences (phase1 workflows were not tested)

davidlange6 added a commit that referenced this pull request Dec 23, 2015
Set phase1 track algorithms properly
@davidlange6 davidlange6 merged commit c26b328 into cms-sw:CMSSW_8_0_X Dec 23, 2015
@makortel makortel deleted the phase1Iterations branch October 20, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants