Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dtChamberEfficiency for Heavy Ions #12839

Merged
merged 5 commits into from Dec 30, 2015
Merged

Conversation

fcavallo
Copy link
Contributor

There were two problems:

  1. StandAloneSETMuons not existing in HI express data set
  2. a cut on the number of recHits associated to StandAlone being too tight for HI
    (it is 20 for pp, I had to decrease it to 5 for HI, see attachment)

frhisto

The newly created file
/DQM/DTMonitorModule/python/dtChamberEfficiencyHI_cfi.py
is now included in
/DQM/DTMonitorModule/python/dtDQMOfflineSources_HI_cff.py
(newly created as well)

In order to actually use it I modified
https://github.com/fcavallo/cmssw/blob/HIfix/DQMOffline/Configuration/python/DQMOfflineHeavyIons_cff.py#L11

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fcavallo (Francesca Romana Cavallo) for CMSSW_8_0_X.

It involves the following packages:

DQM/DTMonitorModule
DQMOffline/Configuration

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Dec 22, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10374/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Dec 30, 2015

+1
not sure if and when there will be some HI data reprocessing. it may be useful to have this in 76 as well.
ciao and thanks,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Dec 30, 2015
fix dtChamberEfficiency for Heavy Ions
@davidlange6 davidlange6 merged commit 85922e4 into cms-sw:CMSSW_8_0_X Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants