Moved Services headers from include to src

[Dr15Jones]

PrintLoadingPlugins and Timing are not Services with which users should interact. Therefore their headers do not need to be included in any code outside of their package.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10406/console

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

-1
Tested at: 14dd2f6
I found an error when building:

>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/src/FWCore/Services/src/JobReportService.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/src/FWCore/Services/src/LoadAllDictionaries.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/src/FWCore/Services/src/PrintLoadingPlugins.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/src/FWCore/Services/src/Memory.cc 
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/src/FWCore/Services/src/PrintLoadingPlugins.cc:16:0:
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/poison/FWCore/Services/interface/PrintLoadingPlugins.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-27-0900/src/FWCore/Services/src/PrintLoadingPlugins.cc:44:1: error: 'PrintLoadingPlugins' does not name a type
 PrintLoadingPlugins::PrintLoadingPlugins()
 ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12855/10406/summary.html

[cmsbuild]

Pull request #12855 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10407/console

[cmsbuild]

+1
Tested at: 628d4f1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12855/10407/summary.html

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12855/10407/summary.html

[Dr15Jones]

Thanks!