Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Service interfaces from users #12860

Merged
merged 2 commits into from Dec 31, 2015

Conversation

Dr15Jones
Copy link
Contributor

Many framework Services are not meant to be called by users. By removing their headers and putting their source code in the plugins directory it is now impossible for users to access them.

Dr15Jones and others added 2 commits December 30, 2015 15:49
Many framework Services are not meant to be called by users. By
removing their headers and putting their source code in the plugins
directory it is now impossible for users to access them.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Services
SimGeneral/MixingModule

@smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10412/console

@Dr15Jones
Copy link
Contributor Author

@davidlange6 the simulation signature is only needed because I had to remove an unnecessary include of FWCore/Services/src/Memory.h from files under control by simulation.

@Dr15Jones
Copy link
Contributor Author

+1
assuming everything compiles correctly

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Dec 31, 2015
@davidlange6 davidlange6 merged commit b737576 into cms-sw:CMSSW_8_0_X Dec 31, 2015
@Dr15Jones Dr15Jones deleted the removeServiceHeaders branch January 6, 2016 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants