Remove unneeded member data from ProductRegistry::Transients

[Dr15Jones]

The Transients data member held a copy of the productList_ with the only difference being the value were const. This data member was kept in synch with productList_ but the data member itself was never used for any operations.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/Provenance

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[Dr15Jones]

please test

[Dr15Jones]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10422/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

-1

Tested at: 9a9cb74
I found errors in the following unit tests:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12865/10422/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ae856f2
06e97ac
7bf5f82
087fcf0
2ce127f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12865/10422/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12865/10422/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12865/10422/summary.html

[Dr15Jones]

@smuzaffar I'm unable to visually find which unit test failed. Can you find it?

[smuzaffar]

@Dr15Jones , at the end of the unit test log I see

>> Tests for package PhysicsTools/PatAlgos ran.
gmake: *** [unittests_RunThat_t] Terminated

Jenkins job also took more than 5 hours, so it could be that unit tests were killed after 2 hours

[Dr15Jones]

Test failure is unrelated to this pull request.