Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add histograms vs. track reference point to MultiTrackValidator #12878

Merged
merged 2 commits into from Jan 16, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jan 6, 2016

This PR adds the following histograms to MultiTrackValidator

  • fake, duplicate, and pileup rate vs. track reference point xy and z
    • to complement efficiency vs. TrackingParticle vertex xy and z
  • duplicate rate vs. DeltaR
    • to make the set of plots vs. DeltaR complete (efficiency, fake rate, and pileup rate are already there)

In addition the tracking validation plot script is updated to include these plots. (included now in #12893)

Tested in 800pre4, no changes expected in existing plots.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@VinInn
Copy link
Contributor

VinInn commented Jan 6, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10431/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

@makortel
Copy link
Contributor Author

makortel commented Jan 8, 2016

Since there has been ~no progress on the review, I took the opportunity and moved the plot script update (commit 86cabd3) to #12893 to avoid conflicts. The remaining two commits in this branch are untouched.

@makortel
Copy link
Contributor Author

Could DQM (@deguio, @vanbesien) please review and sign? Thanks.

Do we need another round of tests because I removed the last, tested commit? (the bot seems to think the tests have been started but I doubt that)

@deguio
Copy link
Contributor

deguio commented Jan 15, 2016

+1

@deguio
Copy link
Contributor

deguio commented Jan 15, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10547/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 16, 2016
Add histograms vs. track reference point to MultiTrackValidator
@cmsbuild cmsbuild merged commit 9f8104c into cms-sw:CMSSW_8_0_X Jan 16, 2016
@makortel makortel deleted the mtvFakeVsRefPoint branch October 20, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants