-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logical not in PFTauSelectorDefinition::select #12879
Conversation
Logical not is applied to a float, which is wrong: RecoTauTag/TauTagTools/plugins/PFTauSelectorDefinition.h:73:34: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] While tracking the change I went to CVS archive to figure out what the correct condition in if-statement. To my surprise there was a change in PFTauSelectorDefinition.h (incl. the fix to this issue) which was not in GIT migration. GIT migration was done using CMSSW_6_2_0_pre8 and this is post-CMSSW_6_2_0_pre8 change in CVS. The changeset: http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/RecoTauTag/TauTagTools/plugins/PFTauSelectorDefinition.h?r1=1.10&r2=1.11 Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_8_0_X. It involves the following packages: RecoTauTag/TauTagTools @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 for #12879 67746fa
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Fix logical not in PFTauSelectorDefinition::select
Logical not is applied to a float, which is wrong:
While tracking the change I went to CVS archive to figure out what the
correct condition in if-statement. To my surprise there was a change in
PFTauSelectorDefinition.h (incl. the fix to this issue) which was not in
GIT migration. GIT migration was done using CMSSW_6_2_0_pre8 and this is
post-CMSSW_6_2_0_pre8 change in CVS.
The changeset:
http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/RecoTauTag/TauTagTools/plugins/PFTauSelectorDefinition.h?r1=1.10&r2=1.11
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch