Fix logical not in PFTauSelectorDefinition::select

[davidlt]

Logical not is applied to a float, which is wrong:

RecoTauTag/TauTagTools/plugins/PFTauSelectorDefinition.h:73:34:
warning: logical not is only applied to the left hand side of comparison
[-Wlogical-not-parentheses]

While tracking the change I went to CVS archive to figure out what the
correct condition in if-statement. To my surprise there was a change in
PFTauSelectorDefinition.h (incl. the fix to this issue) which was not in
GIT migration. GIT migration was done using CMSSW_6_2_0_pre8 and this is
post-CMSSW_6_2_0_pre8 change in CVS.

The changeset:
http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/RecoTauTag/TauTagTools/plugins/PFTauSelectorDefinition.h?r1=1.10&r2=1.11

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_8_0_X.

It involves the following packages:

RecoTauTag/TauTagTools

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10434/console

[cmsbuild]

+1
Tested at: 67746fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12879/10434/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
52defa3
5c756f4
cc54e0d
08c71f4
cedfb62
9dde493
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12879/10434/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12879/10434/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12879/10434/summary.html

[slava77]

+1

for #12879 67746fa

• code change is correct; most (all used in standard workflows?) tau discriminants are effectively booleans (double values 0 or 1), so the code was working "correctly" before
• jenkins tests pass and comparisons with the baseline show no differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar