-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron validation miniAOD V0 80X #12895
Electron validation miniAOD V0 80X #12895
Conversation
A new Pull Request was created by @archiron (Chiron) for CMSSW_8_0_X. It involves the following packages: Configuration/StandardSequences @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
Why do you have so many commits with exact same message and each commit with a single file (checked only a few commits)? |
by same msg do you mean with same comment "web page electron modification" for example ? If yes, this is because the modifications are only of 2 types : minor modifications for wab pages monitoring the histos (web page electron modification) and a more important modifcation with miniAOD implementation ("miniAOD electron modification) |
only 40 commits is still better than over 200 in the previous PR. |
Instead make two commits with two different changes. Then subject line could contains "miniAOD electron modification" (but I would make it more specific) and then add a proper description in commit message (which you have in PR). Otherwise I consider this trashing GIT history (making it harder read). Decent commit message example: rpm-software-management/rpm@a655cee Some reading: |
@deguio |
please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step2_TTbar+TTbarFS+HARVESTFS.log 135.4 step2 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step2_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log 9.0 step4 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log 25.0 step4 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log you can see the results of the tests here: |
Pull request #12895 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
corrections have been made to take into account some typing errors. |
Pull request #12895 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
Preparing to run 135.4 ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS Preparing to run 9.0 Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST Preparing to run 25.0 TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT |
please test |
The tests are being triggered in jenkins. |
-1 >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoEgamma/plugins/PhotonValidatorMiniAOD.cc >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoEgamma/plugins/SealModule.cc >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoEgamma/plugins/TkConvValidator.cc >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoHI/plugins/HiBasicGenTest.cc /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoEgamma/plugins/ElectronMcMiniAODSignalValidator.cc: In member function 'virtual void ElectronMcSignalValidatorMiniAOD::analyze(const edm::Event&, const edm::EventSetup&)': /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoEgamma/plugins/ElectronMcMiniAODSignalValidator.cc:374:59: error: expected ',' or ';' before ')' token double one_over_pt = 1. / bestGsfElectron.pt()); ^ In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/external/clhep/2.2.0.4-kpegke/include/CLHEP/Units/GlobalPhysicalConstants.h:2:0, from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-28-2300/src/Validation/RecoEgamma/plugins/ElectronMcMiniAODSignalValidator.cc:24: /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/external/clhep/2.2.0.4-kpegke/include/CLHEP/Units/PhysicalConstants.h: At global scope: you can see the results of the tests here: |
a parenthesis needs a fix |
@archiron could you provide the one character fix today? I will approve after. |
removing parenthesis on line 374
Pull request #12895 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 |
Electron validation miniAOD V0 80X
New version of the PR12272. All was made with CMSSW_8_0_0_pre4
miniAOD validation is introduced. New modules have been added (electronMcMiniAODSignalValidator and electronMcMiniAODSignalPostValidator) with _cfg files and _cfi files.
BuildFile.xml and SealModule.cc were updated.
Minor implementations were added into ElectronMcSignalValidator.cc to take into account miniAOD differences. With this histos, it is possible to compare miniAOD vs RECO .
Some minors corrections have been made on "classical" files sur as OvalFile, electronCompare.C..
@beaudett