Update SiPixelRawToDigi.cc #12897
Update SiPixelRawToDigi.cc #12897
Conversation
|
A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_7_5_X. It involves the following packages: EventFilter/SiPixelRawToDigi @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
| @@ -97,6 +98,11 @@ SiPixelRawToDigi::SiPixelRawToDigi( const edm::ParameterSet& conf ) | |||
| usePhase1 = config_.getParameter<bool> ("UsePhase1"); | |||
| if(usePhase1) edm::LogInfo("SiPixelRawToDigi") << " Use pilot blade data (FED 40)"; | |||
| } | |||
| //CablingMap could have a label //Tav | |||
| CablingMapLabel = ""; | |||
| if (config_.exists("CablingMapLabel")) { | |||
There was a problem hiding this comment.
this "if" is not necessary after the value is added to the ::fillDescriptions method
|
please also make a PR for 80X |
|
@slava77 I did the PR in 8X, do you wish me to correct the if statement of can I leave it like this? Thanks! |
|
please correct the "if". |
|
Pull request #12897 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
|
Pull request #12897 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Adding the option for Cabling Map to have a label (default is no label of course)