Add Pythia8 UserHook for Resonance decay filtering #12901
Conversation
|
A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_8_0_X. It involves the following packages: GeneratorInterface/Pythia8Interface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
I was waiting for comments from @smrenna |
|
I will look at this today. Josh and I discussed this, but I have not actually looked at the code yet. |
|
I just added a comment to the code, where I think there is one mistake. Otherwise, it looks okay. I may have time to try it out later today, but, otherwise, I think you should commit and we can address any issues afterwards. Josh, do you have some validation plots or tables that demonstrate it does what we want? |
|
I checked with the JetMatchingMadgraph hook that the jet matching results don't change adding this code and combining with the resonance decay filter. Of course that doesn't test the full range of possible UserHook functionality. |
|
And yes, agreed there is one mistake in the protections for multiple incompatible hooks, fixing now. |
… for resonance decay filtering and example
bendavid
force-pushed
the
resonanceDecayFilter_80x
branch
from
94f0213
to
e97adde
Compare
|
Ok the issue with the protections is fixed now. |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 DAS Error you can see the results of the tests here: |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
+1 |
Add Pythia8 UserHook for Resonance decay filtering
Allows to retry resonance decays until desired configuration is present. This is much faster than filtering at the event level, since only the resonance decays are retried. It also works for LHE input without throwing away any events, with the caveat that only the decays handled by pythia are retried (but decay products from the lhe level can still be included in the counting, eg for counting the combined number of leptons at LHE + pythia decay level for Higgs associated production, etc)
In order for this new userhook to work with jet matching, emission veto, etc, a further UserHook was required to act as a generic mechanism to run multiple user hooks simultaneously (and this is now used by default)
An example gen fragment is provided in
GeneratorInterface/Pythia8Interface/test/resonanceDecayFilter.py
Immediate use case is some SUSY signal generation which requires some filtering of Higgs decays (two Higgs in each event and requesting at least one H->gamma gamma decay)