Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize provenance constructors using move semantics #12907

Merged
merged 1 commit into from Jan 12, 2016

Conversation

Dr15Jones
Copy link
Contributor

Use move semantics to avoid copying the BranchID parent list.

Use move semantics to avoid copying the BranchID parent list.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/Provenance
FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10456/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 9b29bfd
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12907/10456/summary.html

@Dr15Jones
Copy link
Contributor Author

The test failure appears unrelated to this pull request. The test failed to find file:ttbarForMetTests.root. That file was generated by the same script. From the log output it looks like the generate step failed with a pythia error:

 PYTHIA Error in Pythia::check: charge not conserved  
 PYTHIA Abort from Pythia::forceHadronLevel: check of event revealed problems  
 PYTHIA Error in Pythia::check: unmatched particle energy/momentum/mass  
 PYTHIA Warning in Pythia::check: not quite matched particle energy/momentum/mass  

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Jan 12, 2016
Optimize provenance constructors using move semantics
@davidlange6 davidlange6 merged commit 48adf22 into cms-sw:CMSSW_8_0_X Jan 12, 2016
@Dr15Jones Dr15Jones deleted the optimizeParentage branch February 4, 2016 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants