Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HF 1x1 TP production fixes #12916

Merged
merged 4 commits into from Jan 20, 2016
Merged

HF 1x1 TP production fixes #12916

merged 4 commits into from Jan 20, 2016

Conversation

matz-e
Copy link
Contributor

@matz-e matz-e commented Jan 12, 2016

I have discovered two bugs in the code ported:

  • long fibers were used instead of short ones
  • ieta rings ±29 were not properly integrated with ieta rings ±30

With the fixes in this PR, 1x1 TP matching to the 2x3 TP is improved a lot.

@matz-e
Fix variable typo.
aae4593
@matz-e
Fix accounting for ieta ring ±29 in 1x1 TPs.
363b100 
With the 1x1 TP geometry, the ieta ring 29 gets added to ieta ring 30 for
1x1 TP.  Properly sum up the values by using a vector of samples instead of
a single sample in the intermediate data aggregation.
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 12, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_0_X.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10468/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 363b100
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12916/10468/summary.html

@matz-e
Merge long and short fibers again.
d142903 
Keep long and short fibers together and treat them at the same time.  More
in line with Alex Gudes original algo.
@cmsbuild
Copy link
Contributor

Pull request #12916 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12916/10468/summary.html

@cmsbuild
Copy link
Contributor

Pull request #12916 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10522/console

@cmsbuild
Copy link
Contributor

+1
Tested at: f025176
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12916/10522/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12916/10522/summary.html

@abdoulline
Copy link

May we have it in pre5, please?
Here is Matthias' results with this update
https://indico.cern.ch/event/483399/session/0/contribution/5/attachments/1212017/1768073/hf_tp_update.pdf

@davidlange6
Copy link
Contributor

@mulhearn - ping

@abdoulline
Copy link

@mulhearn - ping
(it's quite inconvenien to always merge this PR before running any further development/test jobs...)

@davidlange6
Copy link
Contributor

I declare that @mulhearn signed it once already...

davidlange6 added a commit that referenced this pull request Jan 20, 2016
@davidlange6
Merge pull request #12916 from matz-e/hf-1x1-tp-fixes
0dcc75d 
HF 1x1 TP production fixes
@davidlange6 davidlange6 merged commit 0dcc75d into cms-sw:CMSSW_8_0_X Jan 20, 2016
cmsbuild added a commit that referenced this pull request Jan 20, 2016
@cmsbuild
Merge pull request #12916 from matz-e/hf-1x1-tp-fixes
1fb8f50
@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@mulhearn
Copy link
Contributor

Sorry for missed ping...

@matz-e matz-e deleted the hf-1x1-tp-fixes branch September 15, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matz-e @cmsbuild @mulhearn @davidlange6 @abdoulline