Fix DQM standalone compilation #12934
Conversation
DQM core code needs to be compiled outside of the CMSSW FWK into the DQMGUI code. This PR fixes few bugs that have been introduced in the past (commit cms-sw@197ddb3, PR cms-sw#3411). All the include files that are CMSSW related should never be added directly in DQMStore.cc, but to Standalone.h protected by the WITHOUT_CMS_FRAMEWORK condition. A required edm::service namespace was missing, and this bug allowed the original compilation of the code that would have otherwise correctly failed to compile. This indicates that a better way of testing the standalong compilation should be found, but that's not extremely urgent.
|
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_8_0_X. It involves the following packages: DQMServices/Core @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Fix DQM standalone compilation
DQM core code needs to be compiled outside of the CMSSW FWK into the
DQMGUI code. This PR fixes few bugs that have been introduced in the
past (commit
197ddb3,
PR #3411). All the include files
that are CMSSW related should never be added directly in DQMStore.cc,
but to Standalone.h protected by the WITHOUT_CMS_FRAMEWORK condition. A
required edm::service namespace was missing, and this bug allowed the
original compilation of the code that would have otherwise correctly
failed to compile. This indicates that a better way of testing the
standalong compilation should be found, but that's not extremely urgent.