Updates from track-based muon alignment group

[aysent]

This pull request includes updates from the track-based muon alignment group that were developed during LS1 and throughout year 2015:

https://github.com/cms-mual
https://github.com/cms-mual/Alignment

The code has been used to deliver a new alignment of the muon system for Run2 in August and November 2015.

[cmsbuild]

A new Pull Request was created by @aysent (Aysen Tatarinov) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentMonitor
Alignment/MuonAlignment
Alignment/MuonAlignmentAlgorithms

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @battibass, @abbiendi, @jhgoh, @tocheng, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10526/console

[cmsbuild]

-1
Tested at: daaed7a
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

  virtual void addResidual(const TrajectoryStateOnSurface *tsos, const TransientTrackingRecHit *hit) {}
               ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-14-2300/src/Alignment/MuonAlignmentAlgorithms/interface/MuonChamberResidual.h:42:16: note: hidden overloaded virtual function 'MuonChamberResidual::addResidual' declared here: different number of parameters (5 vs 2)
  virtual void addResidual(edm::ESHandle prop, const TrajectoryStateOnSurface *, const TrackingRecHit *, double, double) = 0;
               ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-14-2300/src/Alignment/MuonAlignmentAlgorithms/src/MuonTrackCSCChamberResidual.cc:22:12: error: unused variable 'chamber' [-Werror,-Wunused-variable]
  CSCDetId chamber(id.chamberId());
           ^
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-14-2300/src/Alignment/MuonAlignmentAlgorithms/src/MuonTrackDT13ChamberResidual.cc:5:
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-14-2300/src/Alignment/MuonAlignmentAlgorithms/interface/MuonTrackDT13ChamberResidual.h:20:16: warning: 'MuonTrackDT13ChamberResidual::addResidual' hides overloaded virtual function [-Woverloaded-virtual]
  virtual void addResidual(const TrajectoryStateOnSurface *tsos, const TransientTrackingRecHit *hit) {}


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12955/10526/summary.html

[cmsbuild]

Pull request #12955 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12955/10526/summary.html

[cmsbuild]

Pull request #12955 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10891/console

[cmsbuild]

+1
Tested at: ddadb92
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12955/10891/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12955/10875/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12955/10891/summary.html

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1