Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare more framework non-const statics const or atomic #1296

Merged
merged 2 commits into from Nov 4, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 2, 2013

This pull request is for thread safety in the framework. Some more non const statics that are never modified are declared const, snd some that are modified are declared std::atomic. One that is never read is removed.
Tested with checkdeps -a and the relval matrix.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Declare more framework non-const statics const or atomic

It involves the following packages:

FWCore/PluginManager
FWCore/Services
FWCore/Framework

@Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@@ -25,7 +27,7 @@
~ProblemTracker();
ProblemTracker(const ProblemTracker&);

static bool dead_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable should just be removed. It is set in three places but never read.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2013

Pull request #1296 was updated. @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

nclopezo commented Nov 4, 2013

ktf added a commit that referenced this pull request Nov 4, 2013
Multithreading fixes -- Declare more framework non-const statics const or atomic
@ktf ktf merged commit 1e22428 into cms-sw:CMSSW_7_0_X Nov 4, 2013
@wmtan wmtan deleted the MoreThreadSafetyFixes branch November 4, 2013 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants