Conddb v2 remove v1 deps 2

[ggovi]

• Clean up from conddb v1: removed dependencies from packages:
  CondCore/DBCommon
  CondCore/ORA
  CondCore/MetaDataService
  CondCore/TagCollection
• Added TagLog functionality

[cmsbuild]

A new Pull Request was created by @ggovi for CMSSW_8_0_X.

It involves the following packages:

Alignment/CocoaApplication
Alignment/CocoaFit
Alignment/CommonAlignmentAlgorithm
Alignment/MuonAlignment
CalibCalorimetry/CaloMiscalibTools
CalibCalorimetry/EcalCorrelatedNoiseAnalysisModules
CalibCalorimetry/EcalTPGTools
CalibMuon/CSCCalibration
CalibTracker/SiPixelConnectivity
CalibTracker/SiStripDCS
CalibTracker/SiStripESProducers
CommonTools/ConditionDBWriter
CondCore/BeamSpotPlugins
CondCore/CondDB
CondCore/DBCommon
CondCore/DBOutputService
CondCore/EgammaPlugins
CondCore/HIPlugins
CondCore/MetaDataService
CondCore/ORA
CondCore/PopCon
CondCore/RecoMuonPlugins
CondCore/TagCollection
CondCore/Utilities
CondFormats/Common
CondFormats/DTObjects
CondFormats/EcalObjects
CondFormats/MFObjects
CondFormats/PhysicsToolsObjects
CondTools/DT
CondTools/Ecal
CondTools/Hcal
CondTools/L1Trigger
CondTools/RPC
CondTools/RunInfo

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @apfeiffer1, @battibass, @abbiendi, @gbenelli, @tocheng, @argiro, @jlagram, @dkotlins, @jhgoh, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10528/console

[cmsbuild]

-1

Tested at: 2bc59ae
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test TestJetMETCorrectionsModulesJetResolutionObject had ERRORS
---> test testBasicPayload had ERRORS
---> test testPayloadProxy had ERRORS
---> test testConditionDatabase_2 had ERRORS
---> test testConditionDatabase_0 had ERRORS
---> test testFrontier had ERRORS
---> test testConditionDatabase_1 had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestRecoEgammaElectronIdentification had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12960/10528/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12960/10544/summary.html

[ggovi]

@mmusich @franzoni @mulhearn
any objection? I'd like to have this signed for the ORP...

[davidlange6]

@ggovi - you should also sign it...

[ggovi]

+1

[mmusich]

+1

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[davidlange6]

@ggovi - looks like one was missed (or came in just recently) - i will revert this for now, until a fix is available
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_0_X_2016-01-19-2300/Geometry/HcalCommonData

[diguida]

@davidlange6 IIUC it looks like the BuildFile of Geometry/HcalCommonData is missing a reference to CoralBase. I can argue this was included indirectly from some of the DB core packages now removed (most likely CondCore/DBCommon).
I assume the fix is to add

<use   name="CoralBase"/>

for the failing tests.

[diguida]

@davidlange6 giving a quick look with @ggovi the header file CoralBase/Exception.h is a spurious include, as the classes defined therein are not used at all in the test.

[diguida]

@davidlange6 the fix is in https://github.com/cms-sw/diguida/commit/a17e26f7a956bf21848a1bb0ab8b9c40d4a214a3.
Now, I have prepared two branches:

• conddbV2-remove-V1-deps-2: CMSSW_8_0_X...diguida:conddbV2-remove-V1-deps-2 done by cherry-picking https://github.com/cms-sw/diguida/commit/a17e26f7a956bf21848a1bb0ab8b9c40d4a214a3 and rebasing this one on top of CMSSW_8_0_X_2016-01-19-1100:

$ git checkout -b conddbV2-remove-V1-deps-2 ggovi/conddbV2-remove-V1-deps-2
$ git cherry-pick a17e26f
$ git rebase -i CMSSW_8_0_X_2016-01-19-1100

• conddbV2-remove-V1-deps-3: CMSSW_8_0_X...diguida:conddbV2-remove-V1-deps-3 done by reverting a88c79c merged in Revert "Conddb v2 remove v1 deps 2" #13005 and then cherry-picking https://github.com/cms-sw/diguida/commit/a17e26f7a956bf21848a1bb0ab8b9c40d4a214a3

$ git checkout -b conddbV2-remove-V1-deps-3 official-cmssw/CMSSW_8_0_X
$ git revert -m 1 a88c79c
$ git cherry-pick a17e26f

Please let us know which one you would like to become a PR

[diguida]

As a further check, both branches conddbV2-remove-V1-deps-2 and conddbV2-remove-V1-deps-3 have the same modifications, as seen by git:

$ git diff --stat official-cmssw/CMSSW_8_0_X...conddbV2-remove-V1-deps-2 | tail -1
 361 files changed, 5141 insertions(+), 19711 deletions(-)
$ git diff --stat official-cmssw/CMSSW_8_0_X...conddbV2-remove-V1-deps-3 | tail -1
 361 files changed, 5141 insertions(+), 19711 deletions(-)