Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security #13012

ggovi · 2016-01-20T14:30:46Z

Clean up from CondDBv1: removed dependencies from packages: CondCore/DBCommon, CondCore/ORA, CondCore/MetaDataService, CondCore/TagCollection, in particular in Configuration/StandardSequences/python/FrontierConditions_GlobalTag_cfi.py used by cmsDriver to set up condition access.
Added TagLog functionality
Added the possibility to configure Frontier connection in order to request the server sends digital signatures on every response. This is done by setting a string data member in ConnectionPool or the corresponding parameter in a ParameterSet. An unit test has been added. The default is "", so the current behaviour is kept.

…ameter is set to sig, FroNTier requests that the server sends digital signatures on every response. Add frontier security option as a string data member in ConnectionPool, and define appropriate setter. The frontier security option is turned on for all sessions using the same ConnectionPool for configuring the server access via CORAL. Add FroNTier security option in DBParameters PSet of CondDB setup. Put a default value for the authentication path in ConnectionPool. When setting connection parameters from a ParameterSet in ConnectionPool, if a parameter is not defined, keep the values already set in the data members (i.e. default if no other setters called, or the ones currently available). Removed duplicated code for setting table time to live parameters of Condition schema in ConnectionPool. Removed the unused dbFormat parameter in CondDB_cfi.py as we only support CondDBv2, and dropped unused CondDBboost_cfi. New unit test for ConnectionPool. Add a warning about unsupported connection strings. Conflicts: CondCore/CondDB/src/ConnectionPool.cc CondCore/CondDB/src/DbConnectionString.cc

…DBSetup for CondDBv1.

…ugins in CondCore/CondDB

cmsbuild · 2016-01-20T14:31:17Z

A new Pull Request was created by @ggovi for CMSSW_8_0_X.

It involves the following packages:

Alignment/CocoaApplication
Alignment/CocoaFit
Alignment/CommonAlignmentAlgorithm
Alignment/MuonAlignment
CalibCalorimetry/CaloMiscalibTools
CalibCalorimetry/EcalCorrelatedNoiseAnalysisModules
CalibCalorimetry/EcalTPGTools
CalibMuon/CSCCalibration
CalibTracker/SiPixelConnectivity
CalibTracker/SiStripDCS
CalibTracker/SiStripESProducers
CommonTools/ConditionDBWriter
CondCore/BeamSpotPlugins
CondCore/CondDB
CondCore/DBCommon
CondCore/DBOutputService
CondCore/EgammaPlugins
CondCore/HIPlugins
CondCore/MetaDataService
CondCore/ORA
CondCore/PopCon
CondCore/RecoMuonPlugins
CondCore/TagCollection
CondCore/Utilities
CondFormats/Common
CondFormats/DTObjects
CondFormats/EcalObjects
CondFormats/MFObjects
CondFormats/PhysicsToolsObjects
CondTools/DT
CondTools/Ecal
CondTools/Hcal
CondTools/L1Trigger

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @apfeiffer1, @battibass, @abbiendi, @gbenelli, @tocheng, @argiro, @jlagram, @dkotlins, @jhgoh, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

ggovi · 2016-01-20T14:31:28Z

please test

cmsbuild · 2016-01-20T14:31:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10602/console

cmsbuild · 2016-01-20T19:37:26Z

+1
Tested at: 16cf71f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13012/10602/summary.html

cmsbuild · 2016-01-20T20:26:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13012/10602/summary.html

ggovi · 2016-01-21T13:40:21Z

@davidlange6
This PR should fix the problem ( that was probably not visible with merge-topic ). The corresponding branch has been rebased on the IB of 01-19-1100. Is this ok?
Please let us know if you want the branch rather to revert your revert...

mulhearn · 2016-01-21T13:44:06Z

+1

mmusich · 2016-01-22T09:03:12Z

+1

Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security

davidlt · 2016-01-23T14:43:44Z

This had some disastrous effect, Fail: 306 on slc6_amd64_gcc530 which was the only full rebuild.

davidlange6 · 2016-01-24T05:01:25Z

backing out again (lets understand why our build checks aren't catching this via developer builds / PR tests.

davidlt · 2016-01-24T06:37:28Z

Removals. Because IBs / patch releases are based on other releases, whatever is removed is still found in base release.

mmusich · 2016-01-27T15:27:21Z

@ggovi as privately discussed RelVals were failing because of this:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/RecoTauTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py#L3

File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-01-22-2300/python/RecoTauTag/Configuration/RecoPFTauTag_cff.py", line 57, in <module>
    from RecoTauTag.Configuration.HPSPFTaus_cff import *
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-01-22-2300/python/RecoTauTag/Configuration/HPSPFTaus_cff.py", line 32, in <module>
    from RecoTauTag.Configuration.loadRecoTauTagMVAsFromPrepDB_cfi import *
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-01-22-2300/python/RecoTauTag/Configuration/loadRecoTauTagMVAsFromPrepDB_cfi.py", line 3, in <module>
    from CondCore.DBCommon.CondDBSetup_cfi import *
ImportError: No module named DBCommon.CondDBSetup_cfi

ggovi and others added 13 commits January 20, 2016 15:10

Removed CondCore/DBCommon dependencies

74339e2

Removed forgotten file...

62907ea

Fixed more forgotten changes...

fd7abdb

Static const params moved to constexpr

7d6d3e7

Propagated the fixes to the tools

cc9a92a

Added TagLog feature

c5f8c0c

Cleanup: use CondDB ParameterSet defined for CondDBv2 instead of Cond…

5add5ff

…DBSetup for CondDBv1.

Added RelationalAuthenticationService and XMLAuthenticationService pl…

a1cd37a

…ugins in CondCore/CondDB

Bug fix: use the newly defined auth namespace in CondDB.

4de8657

Bug fix: add missing dependencies in plugins BuildFile of CondDB.

1bc014a

Fix for one DBCommon left over...

943b395

Fix for non-required dependencies

16cf71f

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 20, 2016

cmsbuild added l1-pending alca-pending db-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 20, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 20, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 20, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 20, 2016

cmsbuild added l1-approved and removed l1-pending labels Jan 21, 2016

cmsbuild added alca-approved and removed alca-pending labels Jan 22, 2016

davidlange6 added a commit that referenced this pull request Jan 22, 2016

Merge pull request #13012 from ggovi/conddbV2-remove-V1-deps-3

5815af4

Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security

davidlange6 merged commit 5815af4 into cms-sw:CMSSW_8_0_X Jan 22, 2016

cmsbuild added a commit that referenced this pull request Jan 22, 2016

Merge pull request #13012 from ggovi/conddbV2-remove-V1-deps-3

53598a6

davidlange6 mentioned this pull request Jan 24, 2016

Revert "Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security" #13043

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security #13012

Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security #13012

ggovi commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

ggovi commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

ggovi commented Jan 21, 2016

mulhearn commented Jan 21, 2016

mmusich commented Jan 22, 2016

davidlt commented Jan 23, 2016

davidlange6 commented Jan 24, 2016

davidlt commented Jan 24, 2016

mmusich commented Jan 27, 2016

Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security #13012

Cleanup of dependencies from CondDBv1 code by moving to CondDBv2, and new interface for logging and FronTier security #13012

Conversation

ggovi commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

ggovi commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

ggovi commented Jan 21, 2016

mulhearn commented Jan 21, 2016

mmusich commented Jan 22, 2016

davidlt commented Jan 23, 2016

davidlange6 commented Jan 24, 2016

davidlt commented Jan 24, 2016

mmusich commented Jan 27, 2016