cMVAv2 negative/positive configuration files #13014

jpata · 2016-01-20T18:31:33Z

Adds configuration files for negative and positive cMVAv2 b-tagger needed for scale factor measurements. Does not affect reco sequences or event content.

Replaces #13007.
scram b runtests was successful. No more merge conflicts.

cmsbuild · 2016-01-20T18:31:57Z

A new Pull Request was created by @jpata (Joosep Pata) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Combined

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

cvuosalo · 2016-01-20T21:10:56Z

@jpata: Please add to the PR description an explanation of the purpose of this PR and what differences it will create in event content and reconstructed quantities.

jpata · 2016-01-21T14:07:16Z

I have added some description. Please let me know if you need anything else from my side.

cvuosalo · 2016-01-21T16:04:49Z

@cmsbuild please test

cmsbuild · 2016-01-21T16:05:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10666/console

cmsbuild · 2016-01-21T18:43:46Z

+1
Tested at: 7438631
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13014/10666/summary.html

cmsbuild · 2016-01-21T19:54:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13014/10666/summary.html

ferencek · 2016-01-21T21:34:14Z

RecoBTag/Combined/python/combinedMVA_cff.py

@@ -11,6 +11,16 @@
 from RecoBTag.Combined.pfNegativeCombinedMVABJetTags_cfi import *
 from RecoBTag.Combined.pfPositiveCombinedMVABJetTags_cfi import *

-# CombinedMVA V2
+#combined MVA V2
+from RecoBTag.Combined.combinedMVAV2Computer_cfi import *


Here you should only add JetTag producers. All the computers need to go into RecoBTag/Combined/python/combinedMVA_EventSetup_cff.py (see #12848 for reference).

Also, don't forget to add this PR to https://twiki.cern.ch/twiki/bin/view/CMS/BTagSoftwarePullRequests Thanks

cvuosalo · 2016-01-25T23:06:48Z

@jpata: Please note this PR now has merge conflicts.

slava77 · 2016-01-28T23:50:44Z

@pvmulder @jpata
should this PR go to the backburner?
There was no feedback in this thread for almost a week now.

ghost · 2016-01-28T23:58:00Z

@slava77

@jpata mentioned today (offline) that he should be able to solve the conflicts today

Conflicts: RecoBTag/Combined/python/combinedMVA_cff.py removed couts

cmsbuild · 2016-01-29T07:29:16Z

Pull request #13014 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

jpata · 2016-01-29T07:32:03Z

rebased to latest IB, implemented @ferencek-s comments

jpata · 2016-01-29T12:23:06Z

scram b runtests passed for me. could you please comment?

slava77 · 2016-01-29T13:17:32Z

@cmsbuild please test

cmsbuild · 2016-01-29T13:17:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10842/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10844/console

cmsbuild · 2016-01-29T16:13:23Z

+1
Tested at: 478e98f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13014/10844/summary.html

cmsbuild · 2016-01-29T17:01:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13014/10844/summary.html

cvuosalo · 2016-01-29T21:26:18Z

+1

For #13014 478e98f

Adding configuration files for negative and positive cMVAv2 b taggers.There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-01-28-2300 show no significant differences, as expected.

jpata · 2016-02-01T09:00:20Z

any updates needed on my side?

…016-01-19-1100 cMVAv2 negative/positive configuration files

…016-01-19-1100

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 20, 2016

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 20, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 21, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 21, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 21, 2016

ferencek reviewed Jan 21, 2016
View reviewed changes

pvmulder mentioned this pull request Jan 28, 2016

Clean up of btag sequence in standard reco + update of DQM #13098

Merged

jpata added 2 commits January 29, 2016 08:24

added negative/positive cMVAv2 conf files

dc3d971

Conflicts: RecoBTag/Combined/python/combinedMVA_cff.py removed couts

migrated computers

478e98f

jpata force-pushed the cmvav2_negpos_from-CMSSW_8_0_X_2016-01-19-1100 branch from 7438631 to 478e98f Compare January 29, 2016 07:28

cmsbuild removed comparison-available tests-approved labels Jan 29, 2016

cmsbuild added tests-pending comparison-pending labels Jan 29, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 29, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 29, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 29, 2016

davidlange6 added a commit that referenced this pull request Feb 1, 2016

Merge pull request #13014 from jpata/cmvav2_negpos_from-CMSSW_8_0_X_2…

555de60

…016-01-19-1100 cMVAv2 negative/positive configuration files

davidlange6 merged commit 555de60 into cms-sw:CMSSW_8_0_X Feb 1, 2016

cmsbuild added a commit that referenced this pull request Feb 1, 2016

Merge pull request #13014 from jpata/cmvav2_negpos_from-CMSSW_8_0_X_2…

9b0e511

…016-01-19-1100

ferencek mentioned this pull request Mar 11, 2016

cMVAv2 negative/positive configuration files (76X) #13699

Merged

jpata deleted the cmvav2_negpos_from-CMSSW_8_0_X_2016-01-19-1100 branch July 31, 2016 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cMVAv2 negative/positive configuration files #13014

cMVAv2 negative/positive configuration files #13014

jpata commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

cvuosalo commented Jan 20, 2016

jpata commented Jan 21, 2016

cvuosalo commented Jan 21, 2016

cmsbuild commented Jan 21, 2016

cmsbuild commented Jan 21, 2016

cmsbuild commented Jan 21, 2016

ferencek Jan 21, 2016

cvuosalo commented Jan 25, 2016

slava77 commented Jan 28, 2016

ghost commented Jan 28, 2016

cmsbuild commented Jan 29, 2016

jpata commented Jan 29, 2016

jpata commented Jan 29, 2016

slava77 commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cvuosalo commented Jan 29, 2016

jpata commented Feb 1, 2016

cMVAv2 negative/positive configuration files #13014

cMVAv2 negative/positive configuration files #13014

Conversation

jpata commented Jan 20, 2016

cmsbuild commented Jan 20, 2016

cvuosalo commented Jan 20, 2016

jpata commented Jan 21, 2016

cvuosalo commented Jan 21, 2016

cmsbuild commented Jan 21, 2016

cmsbuild commented Jan 21, 2016

cmsbuild commented Jan 21, 2016

ferencek Jan 21, 2016

Choose a reason for hiding this comment

cvuosalo commented Jan 25, 2016

slava77 commented Jan 28, 2016

ghost commented Jan 28, 2016

cmsbuild commented Jan 29, 2016

jpata commented Jan 29, 2016

jpata commented Jan 29, 2016

slava77 commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cvuosalo commented Jan 29, 2016

jpata commented Feb 1, 2016