Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing message #13018

Merged
merged 2 commits into from Jan 21, 2016
Merged

Conversation

bbockelm
Copy link
Contributor

When CMSSW was single-threaded, the following message from the signal handler made sense:

NOTE:The first few functions on the stack are artifacts of processing the signal and can be ignored

This is no longer true! You have to pick through the contents of each thread's stack.

When CMSSW was single-threaded, the following message from the signal handler made sense:

```
NOTE:The first few functions on the stack are artifacts of processing the signal and can be ignored
```

This is no longer true!  You have to pick through the contents of each thread's stack.
Retains the prior whitespace.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@bbockelm
Copy link
Contributor Author

Crap. I used github's in-browser editor and this (for reasons unknown to me) decided to create the branch in the cms-sw account instead of the bbockelm account. Please make sure we delete the branch afterward.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10660/console

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jan 21, 2016
@davidlange6 davidlange6 merged commit cd33a61 into CMSSW_8_0_X Jan 21, 2016
@cmsbuild
Copy link
Contributor

@bbockelm bbockelm deleted the bbockelm-remove-sighandler-message branch January 21, 2016 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants