Esmaeel dqm2016 stage2

[EsmaeelEskandari]

No description provided.

[cmsbuild]

A new Pull Request was created by @EsmaeelEskandari for CMSSW_8_0_X.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10711/console

[cmsbuild]

-1
Tested at: 1903f8d
I found an error when building:

L1TSync_Offline.cc:(.text+0x50c5): undefined reference to `L1TMenuHelper::L1TMenuHelper(edm::EventSetup const&)'
L1TSync_Offline.cc:(.text+0x50ec): undefined reference to`L1TMenuHelper::testAlgos(std::map, std::allocator > > const&)'
L1TSync_Offline.cc:(.text+0x51f0): undefined reference to `L1TMenuHelper::getLUSOTrigger(std::map, std::allocator > > const&, int, L1GtUtils const&)'
L1TSync_Offline.cc:(.text+0x5a9d): undefined reference to`L1TMenuHelper::~L1TMenuHelper()'
L1TSync_Offline.cc:(.text+0x5d88): undefined reference to `L1TMenuHelper::~L1TMenuHelper()'
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc493/src/DQMOffline/L1Trigger/src/DQMOfflineL1Trigger/libDQMOfflineL1Trigger.so] Error 1
Leaving library rule at DQMOffline/L1Trigger
>> Leaving Package DQMOffline/L1Trigger
>> Package DQMOffline/L1Trigger built
>> Subsystem DQMOffline built


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13034/10711/summary.html

[EsmaeelEskandari]

but I didn't use "L1TSync_Offline.cc" at all

[davidlange6]

likely its from your build file changes. What was the motivation for those?

On Jan 25, 2016, at 10:56 AM, EsmaeelEskandari notifications@github.com wrote:

but I didn't use "L1TSync_Offline.cc" at all

—
Reply to this email directly or view it on GitHub.

[EsmaeelEskandari]

If you mean +
I commented that because It was complaining about not finding "L1TStage2mGMT" plugin

[davidlange6]

maybe you are mixing src and plugins in the same directory?

On Jan 25, 2016, at 11:45 AM, EsmaeelEskandari notifications@github.com wrote:

If you mean +
I commented that because It was complaining about not finding "L1TStage2mGMT" plugin

—
Reply to this email directly or view it on GitHub.

[EsmaeelEskandari]

No, They are in different directories.

[cmsbuild]

Pull request #13034 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #13034 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

[EsmaeelEskandari]

I un-commented those lines in BuildFile. Would you please make a test again?

[EsmaeelEskandari]

Would you please make a test?

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10773/console

[cmsbuild]

+1
Tested at: 46e883e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13034/10773/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13034/10773/summary.html

[EsmaeelEskandari]

Sorry I took a look at the comparison DQM plots. There are not any DQM plots produced by "L1TStage2mGMT" and "L1TStage2CaloLayer2" ED Analyzers!!

[EsmaeelEskandari]

Sorry, what should I do now?

[deguio]

the online workflow is not tested here. for that we will need to test at p5.

[EsmaeelEskandari]

So is my codes supposed to be put within official CMSSW now?

[deguio]

yes. I will review again the code in the next few days and let you know in case something else needs to be changed.

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[EsmaeelEskandari]

People in mGMT asked me to change the range and bins of histograms which David told me its expensive to have a wide rangw and a lot of bins.
The new proposed ones are:
pt : 0 -- 255 with 0.5 GeV steps i.e. 510 bins
eta: -2.45 -- 2.45 with 0.011 steps i.e. 445 bins
phi: 0 -- 6.28 with with 0.011 steps i.e. 574 bins
There is the same problem for BMTF and OMTF histograms.
what should I do?

[deguio]

please try to contain the binning as much as possible and submit the PR.
I will check if the changes you propose are something we can afford.

cheers,
F.