-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes subsequent unused return statement in createIfNeeded #13039
Removes subsequent unused return statement in createIfNeeded #13039
Conversation
Removes subsequent unused return statement and resolves 3742 warnings from Clang (3.7.1). Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_8_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Compile tested on |
Short matrix results: |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 4a5f94b ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
Does not seem to be related.
Seems that is't common for this one to fail. @smuzaffar |
please test |
The tests are being triggered in jenkins. |
Testing this is expensive as it rebuilds <700 packages just for 1 unused line :) This is why I tested it locally on more powerful machine. |
Yeah, but the idea would be understand why it failed instead of running it N times until it works :) |
that is why I want to rerun it as the previous run build area is gone so there is no information which can tell me what had goen wrong in previous run. |
@davidlt, unfortunately, in current iteration of PR test, the test testRecoMETMETProducers passed and I could not fidn out any obvious reason why it failed last time. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
-1 Tested at: 4a5f94b you can see the results of the tests here: |
-1 gmake[1]: **\* [CompilePython] Error 1 gmake[1]: Target `PostBuild' not remade because of errors. gmake[1]: Leaving directory`/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-24-2300' gmake: **\* [src] Error 2 gmake: Target `all' not remade because of errors. gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2 you can see the results of the tests here: |
Random failures?
This is completely not related to PR. |
please test |
I don't believe there is anything to be tested here, most likely some limits we hit on the machines. |
-1 Tested at: 4a5f94b ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
Removes subsequent unused return statement in createIfNeeded
Removes subsequent unused return statement and resolves 3742 warnings
from Clang (3.7.1).
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch