Removes subsequent unused return statement in createIfNeeded #13039

davidlt · 2016-01-23T16:41:22Z

Removes subsequent unused return statement and resolves 3742 warnings
from Clang (3.7.1).

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Removes subsequent unused return statement and resolves 3742 warnings from Clang (3.7.1). Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>

cmsbuild · 2016-01-23T16:41:38Z

A new Pull Request was created by @davidlt for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

davidlt · 2016-01-23T16:44:20Z

Compile tested on slc6_amd64_gcc493 and CMSSW_8_0_X_2016-01-22-2300.

davidlt · 2016-01-23T20:24:50Z

Short matrix results: 10 10 9 7 5 1 1 tests passed, 0 0 0 0 0 0 0 failed

davidlange6 · 2016-01-24T05:24:37Z

please test

cmsbuild · 2016-01-24T05:24:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10697/console

cmsbuild · 2016-01-24T09:52:14Z

-1

Tested at: 4a5f94b
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13039/10697/summary.html

cmsbuild · 2016-01-24T10:32:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13039/10697/summary.html

davidlt · 2016-01-25T08:20:39Z

Does not seem to be related.

# Conditions read from  CMS_CONDITIONS  via FrontierProd 
24-Jan-2016 09:12:36 CET  Initiating request to open file file:ttbarForMetTests.root
----- Begin Fatal Exception 24-Jan-2016 09:12:37 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'ttbarForMetTests.root'
   Additional Info:
      [a] Input file file:ttbarForMetTests.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
Failure using recoMET_caloMet_cfg.py: status 84
status = 21504

---> test testRecoMETMETProducers had ERRORS

Seems that is't common for this one to fail. @smuzaffar

smuzaffar · 2016-01-25T08:54:01Z

please test
@davidlt, yes looks like some build machine issue. Lets try to test it again

cmsbuild · 2016-01-25T08:54:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10712/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10720/console

davidlt · 2016-01-25T08:55:15Z

Testing this is expensive as it rebuilds <700 packages just for 1 unused line :) This is why I tested it locally on more powerful machine.

davidlt · 2016-01-25T08:58:36Z

Yeah, but the idea would be understand why it failed instead of running it N times until it works :)

smuzaffar · 2016-01-25T09:01:50Z

that is why I want to rerun it as the previous run build area is gone so there is no information which can tell me what had goen wrong in previous run.
Now I can monitor the build machine to try to find out the reason. If you have any better idea then do let me know

smuzaffar · 2016-01-25T13:13:36Z

@davidlt, unfortunately, in current iteration of PR test, the test testRecoMETMETProducers passed and I could not fidn out any obvious reason why it failed last time.

smuzaffar · 2016-01-25T13:13:39Z

+1

cmsbuild · 2016-01-25T13:13:52Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-01-25T15:50:21Z

-1

Tested at: 4a5f94b
I found errors in the following unit tests:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13039/10712/summary.html

cmsbuild · 2016-01-25T19:17:48Z

-1
Tested at: 4a5f94b
I found an error when building:

gmake[1]: **\* [CompilePython] Error 1
gmake[1]: Target `PostBuild' not remade because of errors.
gmake[1]: Leaving directory`/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-24-2300'
gmake: **\* [src] Error 2
gmake: Target `all' not remade because of errors.
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13039/10720/summary.html

davidlt · 2016-01-25T21:43:52Z

Random failures?

Compiling src/FWCore/Integration/python/__init__.py ...
  File "src/FWCore/Integration/python/__init__.py", line 2
    os.path.abspath(__file__).rsplit('/FWCore/Integration/',1)[0])+'/cfipython/slc6_amd64_gcc493/FWCore/Integration')
                                                                 ^
SyntaxError: invalid syntax

This is completely not related to PR.

davidlange6 · 2016-01-26T08:26:19Z

please test
(but strange)

cmsbuild · 2016-01-26T08:26:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10733/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10738/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10746/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10753/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10757/console

davidlt · 2016-01-26T08:35:28Z

I don't believe there is anything to be tested here, most likely some limits we hit on the machines.

cmsbuild · 2016-01-27T05:01:03Z

-1

Tested at: 4a5f94b
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13039/10757/summary.html

cmsbuild · 2016-01-27T05:45:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13039/10757/summary.html

Removes subsequent unused return statement in createIfNeeded

Removes subsequent unused return statement in createIfNeeded

4a5f94b

Removes subsequent unused return statement and resolves 3742 warnings from Clang (3.7.1). Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 23, 2016

cmsbuild added core-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 23, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 24, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 24, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 24, 2016

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-rejected labels Jan 25, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 25, 2016

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jan 25, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 25, 2016

cmsbuild added tests-pending and removed tests-rejected labels Jan 26, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 26, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 27, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 27, 2016

davidlange6 added a commit that referenced this pull request Jan 27, 2016

Merge pull request #13039 from davidlt/remove-return-createIfNeeded

341a685

Removes subsequent unused return statement in createIfNeeded

davidlange6 merged commit 341a685 into cms-sw:CMSSW_8_0_X Jan 27, 2016

cmsbuild added a commit that referenced this pull request Jan 27, 2016

Merge pull request #13039 from davidlt/remove-return-createIfNeeded

a377db0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes subsequent unused return statement in createIfNeeded #13039

Removes subsequent unused return statement in createIfNeeded #13039

davidlt commented Jan 23, 2016

cmsbuild commented Jan 23, 2016

davidlt commented Jan 23, 2016

davidlt commented Jan 23, 2016

davidlange6 commented Jan 24, 2016

cmsbuild commented Jan 24, 2016

cmsbuild commented Jan 24, 2016

cmsbuild commented Jan 24, 2016

davidlt commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

davidlt commented Jan 25, 2016

davidlt commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

davidlt commented Jan 25, 2016

davidlange6 commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

davidlt commented Jan 26, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

Removes subsequent unused return statement in createIfNeeded #13039

Removes subsequent unused return statement in createIfNeeded #13039

Conversation

davidlt commented Jan 23, 2016

cmsbuild commented Jan 23, 2016

davidlt commented Jan 23, 2016

davidlt commented Jan 23, 2016

davidlange6 commented Jan 24, 2016

cmsbuild commented Jan 24, 2016

cmsbuild commented Jan 24, 2016

cmsbuild commented Jan 24, 2016

davidlt commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

davidlt commented Jan 25, 2016

davidlt commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

smuzaffar commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

davidlt commented Jan 25, 2016

davidlange6 commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

davidlt commented Jan 26, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Jan 27, 2016